0021274: Wrong message when you do not have correctly defined taxes

Description

Wrong message when you do not have correctly defined taxes

Steps To Reproduce

Login in the WebPOS with taxes bad configured and after create a receipt try to print.

When you push the button "Print", the function "calculateTaxes(callback)" is called (inside the file dataordertaxes.js).

If the function does not find any tax, the error "ERROR! Uncaught TypeError: Cannot read property 'length of null'" is shown, but the proper message will be "No Tax Rate Found"

Proposed Solution

One idea can be, inside the file dataordertaxes.js change:

if (coll.length === 0) {
throw 'No tax rate found';
}

for

if (coll == null || coll.length === 0) {
throw 'No tax rate found';
}

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0021606

closed

migueldejuana

It is necessary to define region and country to the store Organization and related Business Partner

Notes
(0051046) jecharri (viewer) 2012-08-01 08:54	ticket 16401 15/10/2012 3:28 AM

(0051992) hgbot (developer) 2012-09-11 14:07	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 1e333312bf29d7f5bda37aaa3924a1794bec1c91 Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Sep 11 14:06:40 2012 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e333312bf29d7f5bda37aaa3924a1794bec1c91 [^] fixed issue 21274: Correct message is shown when taxes aren't found --- M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js ---

Issue History
Date Modified	Username	Field	Change
2012-08-01 08:54	jecharri	New Issue
2012-08-01 08:54	jecharri	Assigned To	=> adrianromero
2012-08-01 08:54	jecharri	OBNetwork customer	=> Yes
2012-08-01 08:54	jecharri	Note Added: 0051046
2012-08-02 10:53	jonalegriaesarte	Assigned To	adrianromero => jecharri
2012-08-08 08:49	jecharri	Assigned To	jecharri => adrianromero
2012-09-11 12:22	adrianromero	Relationship added	related to 0021606
2012-09-11 14:07	hgbot	Checkin
2012-09-11 14:07	hgbot	Note Added: 0051992
2012-09-11 14:07	hgbot	Status	new => resolved
2012-09-11 14:07	hgbot	Resolution	open => fixed
2012-09-11 14:07	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e333312bf29d7f5bda37aaa3924a1794bec1c91 [^]
2012-09-25 13:09	adrianromero	Status	resolved => closed