Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021274Retail ModulesWeb POSpublic2012-08-01 08:542012-09-25 13:09
Reporterjecharri 
Assigned Toadrianromero 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021274: Wrong message when you do not have correctly defined taxes
DescriptionWrong message when you do not have correctly defined taxes
Steps To ReproduceLogin in the WebPOS with taxes bad configured and after create a receipt try to print.

When you push the button "Print", the function "calculateTaxes(callback)" is called (inside the file dataordertaxes.js).

If the function does not find any tax, the error "ERROR! Uncaught TypeError: Cannot read property 'length of null'" is shown, but the proper message will be "No Tax Rate Found"
Proposed SolutionOne idea can be, inside the file dataordertaxes.js change:

if (coll.length === 0) {
            throw 'No tax rate found';
}

for

if (coll == null || coll.length === 0) {
            throw 'No tax rate found';
}
Additional Information
TagsNo tags attached.
Relationships
related to defect 0021606 closed migueldejuana It is necessary to define region and country to the store Organization and related Business Partner 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-01 08:54jecharriNew Issue
2012-08-01 08:54jecharriAssigned To => adrianromero
2012-08-01 08:54jecharriOBNetwork customer => Yes
2012-08-01 08:54jecharriNote Added: 0051046
2012-08-02 10:53jonalegriaesarteAssigned Toadrianromero => jecharri
2012-08-08 08:49jecharriAssigned Tojecharri => adrianromero
2012-09-11 12:22adrianromeroRelationship addedrelated to 0021606
2012-09-11 14:07hgbotCheckin
2012-09-11 14:07hgbotNote Added: 0051992
2012-09-11 14:07hgbotStatusnew => resolved
2012-09-11 14:07hgbotResolutionopen => fixed
2012-09-11 14:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e333312bf29d7f5bda37aaa3924a1794bec1c91 [^]
2012-09-25 13:09adrianromeroStatusresolved => closed

Notes
(0051046)
jecharri   
2012-08-01 08:54   
ticket 16401

15/10/2012 3:28 AM
(0051992)
hgbot   
2012-09-11 14:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e333312bf29d7f5bda37aaa3924a1794bec1c91
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Sep 11 14:06:40 2012 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e333312bf29d7f5bda37aaa3924a1794bec1c91 [^]

fixed issue 21274: Correct message is shown when taxes aren't found

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---