Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0009963 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | have not tried | 2009-07-20 13:35 | 2009-07-29 00:00 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 2.50MP3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e82f8f4f93e5 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0009963: Lots of reports define a copy of the xsql method selectBpartner/selectMproduct and using these from other reports. | |||||||
| Description | This cross report dependencies make customization of reports harder as necessary, and the multiple definition of the same method should be centralized. | |||||||
| Proposed Solution | Move the two methods into a public Utility file Change all reports to use the public methods (removes the cross report dependency) Remove the copy of the methods from the individual reports xsql-files | |||||||
| Tags | 250MP3releasecandidate | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0018416) hgbot (developer) 2009-07-20 13:51 |
Repository: erp/devel/pi Changeset: e82f8f4f93e585738b21475c792caafbaca65d43 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Mon Jul 20 13:51:34 2009 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e82f8f4f93e585738b21475c792caafbaca65d43 [^] Fixed 9963: Remove some more cross dependencies between reports - Define a new public xsql utility file: info/SelectorUtility_data.xsql which contains the selectBPartner, selectMProduct utility methods which are used by nearly all users of the BPartnerMultiple and ProductMultiple selectors - Use this new methods in all reports from ad_reports - Remove the scattered duplicate definitions of these two methods - Remove file ReportInOut_data.xsql as it is unused after this change - Remove some unused SqlMethod from ReportProjectBuildingSite (non-public xsql file) --- M src/org/openbravo/erpCommon/ad_reports/GenerateModel347.java M src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportAccountingCountDimensionalAnalyses.java M src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java M src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment.java M src/org/openbravo/erpCommon/ad_reports/ReportDebtPaymentTrack.java M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerEdition.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportOffer.java M src/org/openbravo/erpCommon/ad_reports/ReportOffer_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportPricelist_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSite.java M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSiteJR.java M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSite_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyze_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.java M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartnerJR.java M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartner_data.xsql A src/org/openbravo/erpCommon/info/SelectorUtility_data.xsql R src/org/openbravo/erpCommon/ad_reports/ReportInOut_data.xsql --- |
|
(0018417) shuehner (administrator) 2009-07-20 13:53 |
@qa: The change affects the same functionality per report shown in the commit: If the report is called from some other place and the ProductMultiple or BPartnerMultiple selectors are pre-filled with some values, so that these values are directly shown when the reports parameter page is opened. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-07-20 13:35 | shuehner | New Issue | |
| 2009-07-20 13:35 | shuehner | Assigned To | => shuehner |
| 2009-07-20 13:51 | hgbot | Checkin | |
| 2009-07-20 13:51 | hgbot | Note Added: 0018416 | |
| 2009-07-20 13:51 | hgbot | Status | new => resolved |
| 2009-07-20 13:51 | hgbot | Resolution | open => fixed |
| 2009-07-20 13:51 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e82f8f4f93e585738b21475c792caafbaca65d43 [^] |
| 2009-07-20 13:53 | shuehner | Note Added: 0018417 | |
| 2009-07-21 16:24 | psarobe | Fixed in Version | => 2.50MP3 |
| 2009-07-21 16:26 | psarobe | Tag Attached: 250MP3releasecandidate | |
| 2009-07-28 12:41 | psarobe | Status | resolved => closed |
| 2009-07-29 00:00 | anonymous | sf_bug_id | 0 => 2828664 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |