Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009963Openbravo ERPZ. Otherspublic2009-07-20 13:352009-07-29 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP3 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009963: Lots of reports define a copy of the xsql method selectBpartner/selectMproduct and using these from other reports.
DescriptionThis cross report dependencies make customization of reports harder as necessary, and the multiple definition of the same method should be centralized.
Steps To Reproduce
Proposed SolutionMove the two methods into a public Utility file
Change all reports to use the public methods (removes the cross report dependency)
Remove the copy of the methods from the individual reports xsql-files
Additional Information
Tags250MP3releasecandidate
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-20 13:35shuehnerNew Issue
2009-07-20 13:35shuehnerAssigned To => shuehner
2009-07-20 13:35shuehnerOBNetwork customer => No
2009-07-20 13:51hgbotCheckin
2009-07-20 13:51hgbotNote Added: 0018416
2009-07-20 13:51hgbotStatusnew => resolved
2009-07-20 13:51hgbotResolutionopen => fixed
2009-07-20 13:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e82f8f4f93e585738b21475c792caafbaca65d43 [^]
2009-07-20 13:53shuehnerNote Added: 0018417
2009-07-21 16:24psarobeFixed in Version => 2.50MP3
2009-07-21 16:26psarobeTag Attached: 250MP3releasecandidate
2009-07-28 12:41psarobeStatusresolved => closed
2009-07-29 00:00anonymoussf_bug_id0 => 2828664

Notes
(0018416)
hgbot   
2009-07-20 13:51   
Repository: erp/devel/pi
Changeset: e82f8f4f93e585738b21475c792caafbaca65d43
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Mon Jul 20 13:51:34 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e82f8f4f93e585738b21475c792caafbaca65d43 [^]

Fixed 9963: Remove some more cross dependencies between reports
- Define a new public xsql utility file: info/SelectorUtility_data.xsql which contains the selectBPartner, selectMProduct utility methods which are used by nearly all users of the BPartnerMultiple and ProductMultiple selectors
- Use this new methods in all reports from ad_reports
- Remove the scattered duplicate definitions of these two methods
- Remove file ReportInOut_data.xsql as it is unused after this change
- Remove some unused SqlMethod from ReportProjectBuildingSite (non-public xsql file)

---
M src/org/openbravo/erpCommon/ad_reports/GenerateModel347.java
M src/org/openbravo/erpCommon/ad_reports/GenerateModel347_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportAccountingCountDimensionalAnalyses.java
M src/org/openbravo/erpCommon/ad_reports/ReportAgingBalance.java
M src/org/openbravo/erpCommon/ad_reports/ReportDebtPayment.java
M src/org/openbravo/erpCommon/ad_reports/ReportDebtPaymentTrack.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalyses_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerEdition.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportOffer.java
M src/org/openbravo/erpCommon/ad_reports/ReportOffer_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportPricelist_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSite.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSiteJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSite_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses.java
M src/org/openbravo/erpCommon/ad_reports/ReportRefundInvoiceCustomerDimensionalAnalyses_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
M src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyze_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR_data.xsql
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartnerJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartner_data.xsql
A src/org/openbravo/erpCommon/info/SelectorUtility_data.xsql
R src/org/openbravo/erpCommon/ad_reports/ReportInOut_data.xsql
---
(0018417)
shuehner   
2009-07-20 13:53   
@qa: The change affects the same functionality per report shown in the commit:

If the report is called from some other place and the ProductMultiple or BPartnerMultiple selectors are pre-filled with some values, so that these values are directly shown when the reports parameter page is opened.