Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0009728 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2009-06-30 20:40 | 2009-07-10 14:32 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 2.40MP7 | |||
| Status | closed | Fix in branch | 2.40 | Fixed in SCM revision | 3406f3cb518c | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 2.40 | SCM revision | ||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0009728: All generated pages load the MessagesJS data after loading the page. This extra request should be removed to improve performance | |||||||
| Description | All generated windows make a minimum of two requests: 1.) the html for the window itself 2.) a request to MessagesJS (in 2.50 DynamicJS) to read/preload some error messages. This second request delays the page rendering until its result is recieved. As the error messages only change on language switch this extra request shoul be avoided to improve performance. | |||||||
| Steps To Reproduce | Either: Use firebug or a similar tool and the net panel to see the network request Or: Read apache/tomcat access log on the server to see the requests. Goto to i.e. product edit view See the an extra request to MessagesJS | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0017700) hgbot (developer) 2009-06-30 21:28 |
Repository: erp/stable/2.40 Changeset: 3406f3cb518cc00b24e9eda050de4d5bc8423ed1 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Jun 30 21:27:58 2009 +0200 URL: http://code.openbravo.com/erp/stable/2.40/rev/3406f3cb518cc00b24e9eda050de4d5bc8423ed1 [^] Fixed 9728: Remove unneeded MessagesJS requests from generated windows and search popup part1: - Remove request from edit view and grid view of generated window - Remove request from search popup - Instead take needed data from the menu frame - For this add a request to MEssagesJS to VerticalMenu.html (the menuframe content) --- M src-wad/src/org/openbravo/wad/Template_Edition.html M src-wad/src/org/openbravo/wad/Template_Relation.html M src/org/openbravo/erpCommon/businessUtility/Buscador.html M src/org/openbravo/erpCommon/security/Login_F1.html M src/org/openbravo/erpCommon/utility/VerticalMenu.html M web/js/messages.js M web/js/utils.js --- |
|
(0017701) shuehner (administrator) 2009-06-30 21:29 |
Needed testcases for verifying changes: 1.) search popup displays error message properly goto product edit view the search popup is automatically opened remove all % character in there by default press ok A red error box should be shown as no fields are filled 2.) error messages work in edit view of generated window goto i.e. product edit view (or any other generated window) press ok in the opened search popup to display a single record press delete in the toolbar a popup should be opened displaying the confirmation message. 3.a) error message popup work in grid view of generated window goto i.e. product grid view (or any other generatd window) select (highlight) on record. press delete in the toolbar a popup should be opened displaying the confirmation message. 3.b) error message popup work in grid view of generated window goto i.e. product grid view (or any other generatd window) select (highlight) severals records. click on the 'switch to edit view' icon in the LeftTabsBar. a error message that more than one record is selected should be shown. test another (unchanged) place to check for regression in error message display code 4.) automatically generated parameter popup for a report goto financial management goto Accounting goto analysis tools goto Create Tax Report to not select any record in the dropdown Press ok a red box with an error message: 'This field is needed and cannot be blank' should be shown |
|
(0018108) sureshbabu (reporter) 2009-07-10 14:32 |
Tested working fine |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-06-30 20:41 | shuehner | Type | feature request => backport |
| 2009-06-30 20:41 | shuehner | fix_in_branch | => 2.40 |
| 2009-06-30 21:28 | hgbot | Checkin | |
| 2009-06-30 21:28 | hgbot | Note Added: 0017700 | |
| 2009-06-30 21:28 | hgbot | Status | scheduled => resolved |
| 2009-06-30 21:28 | hgbot | Resolution | open => fixed |
| 2009-06-30 21:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/stable/2.40/rev/3406f3cb518cc00b24e9eda050de4d5bc8423ed1 [^] |
| 2009-06-30 21:29 | shuehner | Note Added: 0017701 | |
| 2009-07-10 14:32 | sureshbabu | Status | resolved => closed |
| 2009-07-10 14:32 | sureshbabu | Note Added: 0018108 | |
| 2009-07-10 14:32 | sureshbabu | Fixed in Version | => 2.40MP7 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |