Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0009725
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 03. Procurement managementminorhave not tried2009-06-30 19:562010-03-10 18:28
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version2.50MP12
StatusclosedFix in branchFixed in SCM revision688a931fa9ed
ProjectionnoneETAnoneTarget Version2.50MP14
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0009725: Date validation does not work properly in generated popups.

DescriptionIn generated popup when you entered something invalid into a date field. The the red error marker next to the field is shown, but it is not displaying any text (instead of the proper error text).

Steps To ReproduceGoto: Procurement Management
Goto: Purchase Order Report
Enter: hello into the date field
Press tab to leave the field.

Expected behavior: red error marker with error text.

Real behavior: red error marker but empty (see attached screenshot)
TagsNo tags attached.
Attached Filespng file icon issue_generated_popup_validate_date.png [^] (53,163 bytes) 2009-06-30 19:57

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0017692)
shuehner (administrator)
2009-06-30 19:57

 Reproducible in minimum 2.50beta and 2.50mp2.
(0017742)
dbaz (viewer)
2009-07-01 17:47
edited on: 2009-07-01 18:12

 The person who made the report or the team in charge of this kind of reports should manage it.

In this case since it is a wad automatism maybe alostale is the right person, but I don't know

If they have big troubles while resolving then they could ask me, but I add a comment where I have found the mistake

Thanks.

David.
(0017743)
dbaz (viewer)
2009-07-01 17:56
edited on: 2009-07-01 18:01

 The problem is that the actual generated code is

  <TABLE border="0" cellspacing="0" cellpadding="0" summary="" class="">
    <TR>
      <TD class="TextBox_ContentCell">
      <TABLE style="border:0px;border-collapse:collapse;">
        <TR>
          <TD style="padding-top: 0px;">
            
            <INPUT type="text" class="dojoValidateValid TextBox_btn_OneCell_width" tabindex="" maxlength="40" name="inpcProjectId_R" id="C_Project_ID_R" value="" required="false" onkeydown="changeToEditingMode('onkeydown');" onkeypress="changeToEditingMode('onkeypress');" oncut="changeToEditingMode('oncut');" onpaste="changeToEditingMode('onpaste');" oncontextmenu="changeToEditingMode('oncontextmenu');" onchange="validateTextBox(this.id);"></INPUT>

          </TD>
        </TR>
      </TABLE>
  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RmissingSpan">
    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">
        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>

        <TD colspan="2" class="missing"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RmissingSpanText"></DIV></TD>
      </TR>
    </TABLE>
  </SPAN>


and it should be

  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RinvalidSpan">
    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">

        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>
        <TD colspan="2" class="invalid"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RinvalidSpanText">* The value entered is not valid.</DIV></TD>
      </TR>
    </TABLE>
  </SPAN>

and if it also required, add:
  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RmissingSpan">

    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">
        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>
        <TD colspan="2" class="missing"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RmissingSpanText">* This value is required.</DIV></TD>
      </TR>
    </TABLE>

  </SPAN>
(0024273)
hgbot (developer)
2010-02-15 15:56

 Repository: erp/devel/pi
Changeset: 688a931fa9edc41d54c7070fbc1d208fe55d9712
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Feb 15 15:57:11 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/688a931fa9edc41d54c7070fbc1d208fe55d9712 [^]

fixed bug 9725: Date validation does not work properly in generated popups

---
M src-wad/src/org/openbravo/wad/Template_ActionButton.html
---
(0024479)
arunkumar (viewer)
2010-02-17 12:08

 Now the red marker appears with the text "The value entered is not valid".

Tested & working fine.
(0024517)
hudsonbot (viewer)
2010-02-18 00:30

 A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/688a931fa9ed [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c1b489fb0a0 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16459.obx [^]

- Issue History
Date Modified Username Field Change
2009-06-30 19:56 shuehner New Issue
2009-06-30 19:56 shuehner Assigned To => rafaroda
2009-06-30 19:56 shuehner OBNetwork customer => No
2009-06-30 19:57 shuehner File Added: issue_generated_popup_validate_date.png
2009-06-30 19:57 shuehner Note Added: 0017692
2009-06-30 19:59 psarobe Status new => scheduled
2009-06-30 19:59 psarobe Assigned To rafaroda => dbaz
2009-06-30 19:59 psarobe fix_in_branch => pi
2009-07-01 17:32 dbaz Assigned To dbaz => shuehner
2009-07-01 17:47 dbaz Note Added: 0017742
2009-07-01 17:47 dbaz Assigned To shuehner => psarobe
2009-07-01 17:56 dbaz Note Added: 0017743
2009-07-01 17:58 dbaz Note Edited: 0017743
2009-07-01 17:59 dbaz Note Edited: 0017743
2009-07-01 18:01 dbaz Note Edited: 0017743
2009-07-01 18:12 dbaz Note Edited: 0017742
2010-01-04 09:27 psarobe Assigned To psarobe => rafaroda
2010-01-04 09:27 psarobe Priority normal => urgent
2010-01-04 09:27 psarobe Category A. Platform => 03. Procurement management
2010-01-04 09:27 psarobe Target Version => 2.50MP13
2010-01-04 09:27 psarobe fix_in_branch pi =>
2010-02-11 18:32 rafaroda Assigned To rafaroda => alostale
2010-02-15 15:56 hgbot Checkin
2010-02-15 15:56 hgbot Note Added: 0024273
2010-02-15 15:56 hgbot Status scheduled => resolved
2010-02-15 15:56 hgbot Resolution open => fixed
2010-02-15 15:56 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/688a931fa9edc41d54c7070fbc1d208fe55d9712 [^]
2010-02-17 12:08 arunkumar Note Added: 0024479
2010-02-17 12:08 arunkumar Status resolved => closed
2010-02-17 12:08 arunkumar Fixed in Version => 2.50MP12
2010-02-18 00:00 anonymous sf_bug_id 0 =>
2010-02-18 00:30 hudsonbot Checkin
2010-02-18 00:30 hudsonbot Note Added: 0024517
2010-03-08 16:06 jpabloae Target Version 2.50MP13 => 2.50MP14
2010-03-10 18:28 anonymous sf_bug_id => 2967925

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker