Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009725Openbravo ERP03. Procurement managementpublic2009-06-30 19:562010-03-10 18:28
Reportershuehner 
Assigned Toalostale 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version2.50MP14Fixed in Version2.50MP12 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009725: Date validation does not work properly in generated popups.
DescriptionIn generated popup when you entered something invalid into a date field. The the red error marker next to the field is shown, but it is not displaying any text (instead of the proper error text).

Steps To ReproduceGoto: Procurement Management
Goto: Purchase Order Report
Enter: hello into the date field
Press tab to leave the field.

Expected behavior: red error marker with error text.

Real behavior: red error marker but empty (see attached screenshot)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng issue_generated_popup_validate_date.png (53,163) 2009-06-30 19:57
https://issues.openbravo.com/file_download.php?file_id=1502&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2009-06-30 19:56shuehnerNew Issue
2009-06-30 19:56shuehnerAssigned To => rafaroda
2009-06-30 19:56shuehnerOBNetwork customer => No
2009-06-30 19:57shuehnerFile Added: issue_generated_popup_validate_date.png
2009-06-30 19:57shuehnerNote Added: 0017692
2009-06-30 19:59psarobeStatusnew => scheduled
2009-06-30 19:59psarobeAssigned Torafaroda => dbaz
2009-06-30 19:59psarobefix_in_branch => pi
2009-07-01 17:32dbazAssigned Todbaz => shuehner
2009-07-01 17:47dbazNote Added: 0017742
2009-07-01 17:47dbazAssigned Toshuehner => psarobe
2009-07-01 17:56dbazNote Added: 0017743
2009-07-01 17:58dbazNote Edited: 0017743
2009-07-01 17:59dbazNote Edited: 0017743
2009-07-01 18:01dbazNote Edited: 0017743
2009-07-01 18:12dbazNote Edited: 0017742
2010-01-04 09:27psarobeAssigned Topsarobe => rafaroda
2010-01-04 09:27psarobePrioritynormal => urgent
2010-01-04 09:27psarobeCategoryA. Platform => 03. Procurement management
2010-01-04 09:27psarobeTarget Version => 2.50MP13
2010-01-04 09:27psarobefix_in_branchpi =>
2010-02-11 18:32rafarodaAssigned Torafaroda => alostale
2010-02-15 15:56hgbotCheckin
2010-02-15 15:56hgbotNote Added: 0024273
2010-02-15 15:56hgbotStatusscheduled => resolved
2010-02-15 15:56hgbotResolutionopen => fixed
2010-02-15 15:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/688a931fa9edc41d54c7070fbc1d208fe55d9712 [^]
2010-02-17 12:08arunkumarNote Added: 0024479
2010-02-17 12:08arunkumarStatusresolved => closed
2010-02-17 12:08arunkumarFixed in Version => 2.50MP12
2010-02-18 00:00anonymoussf_bug_id0 =>
2010-02-18 00:30hudsonbotCheckin
2010-02-18 00:30hudsonbotNote Added: 0024517
2010-03-08 16:06jpabloaeTarget Version2.50MP13 => 2.50MP14
2010-03-10 18:28anonymoussf_bug_id => 2967925

Notes
(0017692)
shuehner   
2009-06-30 19:57   
Reproducible in minimum 2.50beta and 2.50mp2.
(0017742)
dbaz   
2009-07-01 17:47   
(edited on: 2009-07-01 18:12)
The person who made the report or the team in charge of this kind of reports should manage it.

In this case since it is a wad automatism maybe alostale is the right person, but I don't know

If they have big troubles while resolving then they could ask me, but I add a comment where I have found the mistake

Thanks.

David.
(0017743)
dbaz   
2009-07-01 17:56   
(edited on: 2009-07-01 18:01)
The problem is that the actual generated code is

  <TABLE border="0" cellspacing="0" cellpadding="0" summary="" class="">
    <TR>
      <TD class="TextBox_ContentCell">
      <TABLE style="border:0px;border-collapse:collapse;">
        <TR>
          <TD style="padding-top: 0px;">
            
            <INPUT type="text" class="dojoValidateValid TextBox_btn_OneCell_width" tabindex="" maxlength="40" name="inpcProjectId_R" id="C_Project_ID_R" value="" required="false" onkeydown="changeToEditingMode('onkeydown');" onkeypress="changeToEditingMode('onkeypress');" oncut="changeToEditingMode('oncut');" onpaste="changeToEditingMode('onpaste');" oncontextmenu="changeToEditingMode('oncontextmenu');" onchange="validateTextBox(this.id);"></INPUT>

          </TD>
        </TR>
      </TABLE>
  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RmissingSpan">
    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">
        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>

        <TD colspan="2" class="missing"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RmissingSpanText"></DIV></TD>
      </TR>
    </TABLE>
  </SPAN>


and it should be

  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RinvalidSpan">
    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">

        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>
        <TD colspan="2" class="invalid"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RinvalidSpanText">* The value entered is not valid.</DIV></TD>
      </TR>
    </TABLE>
  </SPAN>

and if it also required, add:
  <SPAN class="TextBox_MsgContainer_span" style="display: none;" id="C_Project_ID_RmissingSpan">

    <TABLE class="TextBox_MsgContainer_table">
      <TR class="TextBox_MsgContainer_tr">
        <TD class="TextBox_MsgContainer_td"><DIV class="TextBox_MsgContainer_div"></DIV></TD><TD></TD>
      </TR>
      <TR>
        <TD colspan="2" class="missing"><DIV class="TextBox_MsgContainer_div2" id="C_Project_ID_RmissingSpanText">* This value is required.</DIV></TD>
      </TR>
    </TABLE>

  </SPAN>
(0024273)
hgbot   
2010-02-15 15:56   
Repository: erp/devel/pi
Changeset: 688a931fa9edc41d54c7070fbc1d208fe55d9712
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Feb 15 15:57:11 2010 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/688a931fa9edc41d54c7070fbc1d208fe55d9712 [^]

fixed bug 9725: Date validation does not work properly in generated popups

---
M src-wad/src/org/openbravo/wad/Template_ActionButton.html
---
(0024479)
arunkumar   
2010-02-17 12:08   
Now the red marker appears with the text "The value entered is not valid".

Tested & working fine.
(0024517)
hudsonbot   
2010-02-18 00:30   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/688a931fa9ed [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/7c1b489fb0a0 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.16459.obx [^]