0008530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values

(0024741)
rafaroda (developer)
2010-02-23 12:32

Actually this should be a defect and not a feature request, right?

(0024742)
RenateNieuwkoop (reporter)
2010-02-23 12:48

Since bugs have been CLOSED for me saying that they were not bugs but feature request I'm logging issues as feature request to be on the safe side, but yes, I think it's a bug too.

cheers
Renate

(0025705)
hgbot (developer)
2010-03-24 15:20

Repository: erp/devel/pi
Changeset: 4e778aa6e6a854f5b6de5a0bf8b89704aecc2413
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Wed Mar 24 19:57:34 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^]

Fixes issue 8530: RFE: 2.50 Popup of copy lines for Goods Receipt - Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---

(0025706)
sivaraman (reporter)
2010-03-24 15:32

Prerequisite:

We have Purchase Order for Hat and Shirt with attribute values.

Steps to test:

1. Log on to Openbravo
2. Change role to Openbravo Admin
3. Go to Procurement Management || Transactions || Goods Receipt || Header
4. Create new record and Save it
5. Click 'Create Lines From' button
6. In 'Create lines from' window, select purchase order where we have Hat and Shirt with attribute values

(0026250)
plujan (manager)
2010-04-15 13:00

When testing in PI Oracle I still can reproduce the wrong behavior. Check attached screenshots QA_CopyLinesFromOrder.JPG (resulting screen) and QA_CopyLinesFromOrder2.JPG (the Order in which the attributes were set)

(0026253)
adrianromero (manager)
2010-04-15 13:12

The attributes for Hat and Shirt products work properly but no the attributes for Grand Beer.

The difference is that Grand Beer has lot and expiration date

(0026381)
hudsonbot (developer)
2010-04-19 21:11

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4e778aa6e6a8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

(0026555)
sivaraman (reporter)
2010-04-22 06:33

Repository: erp/devel/pi
Changeset: 1133b8a877a3
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Thu Apr 22 10:10:10 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^] [^]

8530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---

(0026556)
sivaraman (reporter)
2010-04-22 06:35

Prerequisite:
We have Purchase Order for Hat and Grand Beer with attribute values.

Steps to test:

1. Log on to Openbravo
2. Change role to Openbravo Admin
3. Go to Procurement Management || Transactions || Goods Receipt || Header
4. Create new record and Save it
5. Click 'Create Lines From' button
6. In 'Create lines from' window, select purchase order where we have Hat and Grand Beer with attribute values

(0026666)
arunkumar (reporter)
2010-04-26 08:23

Tested Working fine

(0026804)
adrianromero (manager)
2010-04-29 18:30

Needs to be reviewed the solution, not sure whether the approach selected is correct

(0026827)
hgbot (developer)
2010-04-30 18:02

Repository: erp/devel/pi
Changeset: 043c51805371eeeea3f21139727136bd9963d375
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Apr 30 18:01:31 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/043c51805371eeeea3f21139727136bd9963d375 [^]

Fixes issue 0008530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---

(0026828)
adrianromero (manager)
2010-04-30 18:07

* Testing of the issue:
To test the issue, review that in the "copy lines" dialog all attributes values are copied from the purchase order. This purchase order has to have products with several types of attributes. For example Shirt, Paint, Grand Beer from SmallBazzar. Test also that in the shipment created, the attributes where properly copied from the "copy lines" window.

* Explanation of the changeset that fixes the issue:
The previous changese fixed the issue but copying the attribute sets. This new changeset just removes the copy of the attribute sets and just usess the attribute set ids from the purchase order.

* Other areas affected by the changeset:
The only affected area is the Copy Lines dialog that appear in the Shipments window.

(0026913)
arunkumar (reporter)
2010-05-04 14:14

Tested the fix Working fine

(0027468)
hudsonbot (developer)
2010-05-18 21:43

A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/043c51805371 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]

Issue History
Date Modified	Username	Field	Change
2009-04-09 11:37	RenateNieuwkoop	New Issue
2009-04-09 11:37	RenateNieuwkoop	Assigned To	=> rafaroda
2009-04-09 11:37	RenateNieuwkoop	File Added: 090409OrderlinerefonCopylines.jpg
2009-04-23 11:48	rafaroda	Assigned To	rafaroda => pjuvara
2010-02-23 12:32	rafaroda	Relationship added	related to 0011513
2010-02-23 12:32	rafaroda	Note Added: 0024741
2010-02-23 12:33	rafaroda	Issue Monitored: rafaroda
2010-02-23 12:48	RenateNieuwkoop	Note Added: 0024742
2010-02-23 13:00	psarobe	Assigned To	pjuvara => adrianromero
2010-02-23 13:00	psarobe	Priority	normal => urgent
2010-02-23 13:00	psarobe	Severity	minor => major
2010-02-23 13:00	psarobe	Status	new => scheduled
2010-02-23 13:00	psarobe	version	2.50beta => 2.50MP11
2010-02-23 13:00	psarobe	Target Version	=> 2.50MP13
2010-03-08 16:06	jpabloae	Target Version	2.50MP13 => 2.50MP14
2010-03-12 13:47	adrianromero	Type	feature request => defect
2010-03-24 15:16	sivaraman	Assigned To	adrianromero => sivaraman
2010-03-24 15:20	hgbot	Checkin
2010-03-24 15:20	hgbot	Note Added: 0025705
2010-03-24 15:20	hgbot	Status	scheduled => resolved
2010-03-24 15:20	hgbot	Resolution	open => fixed
2010-03-24 15:20	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^]
2010-03-24 15:32	sivaraman	Note Added: 0025706
2010-04-15 13:00	plujan	Note Added: 0026250
2010-04-15 13:00	plujan	Status	resolved => new
2010-04-15 13:00	plujan	Resolution	fixed => open
2010-04-15 13:00	plujan	File Added: QA_CopyLinesFromOrder.JPG
2010-04-15 13:01	plujan	File Added: QA_CopyLinesFromOrder2.JPG
2010-04-15 13:01	plujan	Status	new => scheduled
2010-04-15 13:01	plujan	fix_in_branch	=> pi
2010-04-15 13:12	adrianromero	Note Added: 0026253
2010-04-19 21:11	hudsonbot	Checkin
2010-04-19 21:11	hudsonbot	Note Added: 0026381
2010-04-22 06:32	sivaraman	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^] => http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^]
2010-04-22 06:32	sivaraman	fix_in_branch	pi =>
2010-04-22 06:33	sivaraman	Note Added: 0026555
2010-04-22 06:33	sivaraman	Status	scheduled => resolved
2010-04-22 06:33	sivaraman	Resolution	open => fixed
2010-04-22 06:35	sivaraman	Note Added: 0026556
2010-04-26 08:23	arunkumar	Note Added: 0026666
2010-04-26 08:23	arunkumar	Status	resolved => closed
2010-04-27 00:00	anonymous	sf_bug_id	0 => 2992599
2010-04-29 18:30	adrianromero	Note Added: 0026804
2010-04-29 18:30	adrianromero	Status	closed => new
2010-04-29 18:30	adrianromero	Resolution	fixed => open
2010-04-29 18:31	adrianromero	Status	new => scheduled
2010-04-29 18:31	adrianromero	fix_in_branch	=> pi
2010-04-30 18:02	hgbot	Checkin
2010-04-30 18:02	hgbot	Note Added: 0026827
2010-04-30 18:02	hgbot	Status	scheduled => resolved
2010-04-30 18:02	hgbot	Resolution	open => fixed
2010-04-30 18:02	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^] => http://code.openbravo.com/erp/devel/pi/rev/043c51805371eeeea3f21139727136bd9963d375 [^]
2010-04-30 18:07	adrianromero	Note Added: 0026828
2010-05-04 14:14	arunkumar	Note Added: 0026913
2010-05-04 14:14	arunkumar	Status	resolved => closed
2010-05-18 21:43	hudsonbot	Checkin
2010-05-18 21:43	hudsonbot	Note Added: 0027468

Notes
(0024741) rafaroda (developer) 2010-02-23 12:32	Actually this should be a defect and not a feature request, right?

(0024742) RenateNieuwkoop (reporter) 2010-02-23 12:48	Since bugs have been CLOSED for me saying that they were not bugs but feature request I'm logging issues as feature request to be on the safe side, but yes, I think it's a bug too. cheers Renate

(0025705) hgbot (developer) 2010-03-24 15:20	Repository: erp/devel/pi Changeset: 4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com> Date: Wed Mar 24 19:57:34 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^] Fixes issue 8530: RFE: 2.50 Popup of copy lines for Goods Receipt - Attribute values --- M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql ---

(0025706) sivaraman (reporter) 2010-03-24 15:32	Prerequisite: We have Purchase Order for Hat and Shirt with attribute values. Steps to test: 1. Log on to Openbravo 2. Change role to Openbravo Admin 3. Go to Procurement Management \|\| Transactions \|\| Goods Receipt \|\| Header 4. Create new record and Save it 5. Click 'Create Lines From' button 6. In 'Create lines from' window, select purchase order where we have Hat and Shirt with attribute values

(0026250) plujan (manager) 2010-04-15 13:00	When testing in PI Oracle I still can reproduce the wrong behavior. Check attached screenshots QA_CopyLinesFromOrder.JPG (resulting screen) and QA_CopyLinesFromOrder2.JPG (the Order in which the attributes were set)

(0026253) adrianromero (manager) 2010-04-15 13:12	The attributes for Hat and Shirt products work properly but no the attributes for Grand Beer. The difference is that Grand Beer has lot and expiration date

(0026381) hudsonbot (developer) 2010-04-19 21:11	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/4e778aa6e6a8 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]

(0026555) sivaraman (reporter) 2010-04-22 06:33	Repository: erp/devel/pi Changeset: 1133b8a877a3 Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com> Date: Thu Apr 22 10:10:10 2010 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^] [^] 8530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values --- M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql ---

(0026556) sivaraman (reporter) 2010-04-22 06:35	Prerequisite: We have Purchase Order for Hat and Grand Beer with attribute values. Steps to test: 1. Log on to Openbravo 2. Change role to Openbravo Admin 3. Go to Procurement Management \|\| Transactions \|\| Goods Receipt \|\| Header 4. Create new record and Save it 5. Click 'Create Lines From' button 6. In 'Create lines from' window, select purchase order where we have Hat and Grand Beer with attribute values

(0026666) arunkumar (reporter) 2010-04-26 08:23	Tested Working fine

(0026804) adrianromero (manager) 2010-04-29 18:30	Needs to be reviewed the solution, not sure whether the approach selected is correct

(0026827) hgbot (developer) 2010-04-30 18:02	Repository: erp/devel/pi Changeset: 043c51805371eeeea3f21139727136bd9963d375 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Fri Apr 30 18:01:31 2010 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/043c51805371eeeea3f21139727136bd9963d375 [^] Fixes issue 0008530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values --- M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql ---

(0026828) adrianromero (manager) 2010-04-30 18:07	* Testing of the issue: To test the issue, review that in the "copy lines" dialog all attributes values are copied from the purchase order. This purchase order has to have products with several types of attributes. For example Shirt, Paint, Grand Beer from SmallBazzar. Test also that in the shipment created, the attributes where properly copied from the "copy lines" window. * Explanation of the changeset that fixes the issue: The previous changese fixed the issue but copying the attribute sets. This new changeset just removes the copy of the attribute sets and just usess the attribute set ids from the purchase order. * Other areas affected by the changeset: The only affected area is the Copy Lines dialog that appear in the Shipments window.

(0026913) arunkumar (reporter) 2010-05-04 14:14	Tested the fix Working fine

(0027468) hudsonbot (developer) 2010-05-18 21:43	A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated: Changeset: http://code.openbravo.com/erp/devel/main/rev/043c51805371 [^] Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^] Tests: http://builds.openbravo.com/view/devel-int/ [^] OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]