Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0008530Openbravo ERP03. Procurement managementpublic2009-04-09 11:372010-05-18 21:43
RenateNieuwkoop 
sivaraman 
urgentmajoralways
closedfixed 
5
2.50MP11 
2.50MP14 
Core
No
0008530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values
Procurement Management || Transactions || Goods Receipt || Header

When entering a goods receipt and saving the header, then you do a 'copy lines' and select a Purchase Order.
When there are parts that have Atrribute set values, the values that were on the Purchase Order are not reflected.
I assume that this is done for extra flexibility, but it would be better to reflect the value that is on the Purchase Order with an option to overwrite it.

See snapshot
No tags attached.
related to defect 00115132.50MP11 closed rafaroda Error in m_storage_detail 
jpg 090409OrderlinerefonCopylines.jpg (158,750) 2009-04-09 11:37
https://issues.openbravo.com/file_download.php?file_id=1161&type=bug
jpg

jpg QA_CopyLinesFromOrder.JPG (44,077) 2010-04-15 13:00
https://issues.openbravo.com/file_download.php?file_id=2445&type=bug
jpg

jpg QA_CopyLinesFromOrder2.JPG (76,568) 2010-04-15 13:01
https://issues.openbravo.com/file_download.php?file_id=2446&type=bug
jpg
Issue History
2009-04-09 11:37RenateNieuwkoopNew Issue
2009-04-09 11:37RenateNieuwkoopAssigned To => rafaroda
2009-04-09 11:37RenateNieuwkoopFile Added: 090409OrderlinerefonCopylines.jpg
2009-04-23 11:48rafarodaAssigned Torafaroda => pjuvara
2010-02-23 12:32rafarodaRelationship addedrelated to 0011513
2010-02-23 12:32rafarodaNote Added: 0024741
2010-02-23 12:33rafarodaIssue Monitored: rafaroda
2010-02-23 12:48RenateNieuwkoopNote Added: 0024742
2010-02-23 13:00psarobeAssigned Topjuvara => adrianromero
2010-02-23 13:00psarobePrioritynormal => urgent
2010-02-23 13:00psarobeSeverityminor => major
2010-02-23 13:00psarobeStatusnew => scheduled
2010-02-23 13:00psarobeversion2.50beta => 2.50MP11
2010-02-23 13:00psarobeTarget Version => 2.50MP13
2010-03-08 16:06jpabloaeTarget Version2.50MP13 => 2.50MP14
2010-03-12 13:47adrianromeroTypefeature request => defect
2010-03-24 15:16sivaramanAssigned Toadrianromero => sivaraman
2010-03-24 15:20hgbotCheckin
2010-03-24 15:20hgbotNote Added: 0025705
2010-03-24 15:20hgbotStatusscheduled => resolved
2010-03-24 15:20hgbotResolutionopen => fixed
2010-03-24 15:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^]
2010-03-24 15:32sivaramanNote Added: 0025706
2010-04-15 13:00plujanNote Added: 0026250
2010-04-15 13:00plujanStatusresolved => new
2010-04-15 13:00plujanResolutionfixed => open
2010-04-15 13:00plujanFile Added: QA_CopyLinesFromOrder.JPG
2010-04-15 13:01plujanFile Added: QA_CopyLinesFromOrder2.JPG
2010-04-15 13:01plujanStatusnew => scheduled
2010-04-15 13:01plujanfix_in_branch => pi
2010-04-15 13:12adrianromeroNote Added: 0026253
2010-04-19 21:11hudsonbotCheckin
2010-04-19 21:11hudsonbotNote Added: 0026381
2010-04-22 06:32sivaramanFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^] => http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^]
2010-04-22 06:32sivaramanfix_in_branchpi =>
2010-04-22 06:33sivaramanNote Added: 0026555
2010-04-22 06:33sivaramanStatusscheduled => resolved
2010-04-22 06:33sivaramanResolutionopen => fixed
2010-04-22 06:35sivaramanNote Added: 0026556
2010-04-26 08:23arunkumarNote Added: 0026666
2010-04-26 08:23arunkumarStatusresolved => closed
2010-04-27 00:00anonymoussf_bug_id0 => 2992599
2010-04-29 18:30adrianromeroNote Added: 0026804
2010-04-29 18:30adrianromeroStatusclosed => new
2010-04-29 18:30adrianromeroResolutionfixed => open
2010-04-29 18:31adrianromeroStatusnew => scheduled
2010-04-29 18:31adrianromerofix_in_branch => pi
2010-04-30 18:02hgbotCheckin
2010-04-30 18:02hgbotNote Added: 0026827
2010-04-30 18:02hgbotStatusscheduled => resolved
2010-04-30 18:02hgbotResolutionopen => fixed
2010-04-30 18:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^] => http://code.openbravo.com/erp/devel/pi/rev/043c51805371eeeea3f21139727136bd9963d375 [^]
2010-04-30 18:07adrianromeroNote Added: 0026828
2010-05-04 14:14arunkumarNote Added: 0026913
2010-05-04 14:14arunkumarStatusresolved => closed
2010-05-18 21:43hudsonbotCheckin
2010-05-18 21:43hudsonbotNote Added: 0027468

Notes
(0024741)
rafaroda   
2010-02-23 12:32   
Actually this should be a defect and not a feature request, right?
(0024742)
RenateNieuwkoop   
2010-02-23 12:48   
Since bugs have been CLOSED for me saying that they were not bugs but feature request I'm logging issues as feature request to be on the safe side, but yes, I think it's a bug too.

cheers
Renate
(0025705)
hgbot   
2010-03-24 15:20   
Repository: erp/devel/pi
Changeset: 4e778aa6e6a854f5b6de5a0bf8b89704aecc2413
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Wed Mar 24 19:57:34 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/4e778aa6e6a854f5b6de5a0bf8b89704aecc2413 [^]

Fixes issue 8530: RFE: 2.50 Popup of copy lines for Goods Receipt - Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---
(0025706)
sivaraman   
2010-03-24 15:32   
Prerequisite:

We have Purchase Order for Hat and Shirt with attribute values.

Steps to test:

1. Log on to Openbravo
2. Change role to Openbravo Admin
3. Go to Procurement Management || Transactions || Goods Receipt || Header
4. Create new record and Save it
5. Click 'Create Lines From' button
6. In 'Create lines from' window, select purchase order where we have Hat and Shirt with attribute values
(0026250)
plujan   
2010-04-15 13:00   
When testing in PI Oracle I still can reproduce the wrong behavior. Check attached screenshots QA_CopyLinesFromOrder.JPG (resulting screen) and QA_CopyLinesFromOrder2.JPG (the Order in which the attributes were set)
(0026253)
adrianromero   
2010-04-15 13:12   
The attributes for Hat and Shirt products work properly but no the attributes for Grand Beer.

The difference is that Grand Beer has lot and expiration date
(0026381)
hudsonbot   
2010-04-19 21:11   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/4e778aa6e6a8 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/91d98bda46c1 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17088.obx [^]
(0026555)
sivaraman   
2010-04-22 06:33   
Repository: erp/devel/pi
Changeset: 1133b8a877a3
Author: Sivaraman Rajagopal <sivaraman.rajagopal <at> openbravo.com>
Date: Thu Apr 22 10:10:10 2010 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/1133b8a877a3 [^] [^]

8530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_ShipmentPO.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---
(0026556)
sivaraman   
2010-04-22 06:35   
Prerequisite:
We have Purchase Order for Hat and Grand Beer with attribute values.

Steps to test:

1. Log on to Openbravo
2. Change role to Openbravo Admin
3. Go to Procurement Management || Transactions || Goods Receipt || Header
4. Create new record and Save it
5. Click 'Create Lines From' button
6. In 'Create lines from' window, select purchase order where we have Hat and Grand Beer with attribute values
(0026666)
arunkumar   
2010-04-26 08:23   
Tested Working fine
(0026804)
adrianromero   
2010-04-29 18:30   
Needs to be reviewed the solution, not sure whether the approach selected is correct
(0026827)
hgbot   
2010-04-30 18:02   
Repository: erp/devel/pi
Changeset: 043c51805371eeeea3f21139727136bd9963d375
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Apr 30 18:01:31 2010 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/043c51805371eeeea3f21139727136bd9963d375 [^]

Fixes issue 0008530: RFE: 2.50 Popup of copy lines for Goods Receipt should suggest the Attribute values

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Shipment_data.xsql
---
(0026828)
adrianromero   
2010-04-30 18:07   
* Testing of the issue:
To test the issue, review that in the "copy lines" dialog all attributes values are copied from the purchase order. This purchase order has to have products with several types of attributes. For example Shirt, Paint, Grand Beer from SmallBazzar. Test also that in the shipment created, the attributes where properly copied from the "copy lines" window.

* Explanation of the changeset that fixes the issue:
The previous changese fixed the issue but copying the attribute sets. This new changeset just removes the copy of the attribute sets and just usess the attribute set ids from the purchase order.

* Other areas affected by the changeset:
The only affected area is the Copy Lines dialog that appear in the Shipments window.
(0026913)
arunkumar   
2010-05-04 14:14   
Tested the fix Working fine
(0027468)
hudsonbot   
2010-05-18 21:43   
A changeset related to this issue has been promoted to main after passing a series of tests and an OBX has been generated:

Changeset: http://code.openbravo.com/erp/devel/main/rev/043c51805371 [^]
Merge Changeset: http://code.openbravo.com/erp/devel/main/rev/aa11838d5f80 [^]
Tests: http://builds.openbravo.com/view/devel-int/ [^]
OBX: http://builds.openbravo.com/erp/core/obx/OpenbravoERP-2.50CI.17380.obx [^]