Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
| ID | ||||||||||||
| 0007905 | ||||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| feature request | [Openbravo ERP] A. Platform | major | have not tried | 2009-03-03 06:49 | 2022-02-01 08:09 | |||||||
| Reporter | mtaal | View Status | public | |||||||||
| Assigned To | Triage Platform Base | |||||||||||
| Priority | high | Resolution | out of date | Fixed in Version | ||||||||
| Status | new | Fix in branch | Fixed in SCM revision | 652e31de84ca | ||||||||
| Projection | none | ETA | none | Target Version | pi | |||||||
| OS | Any | Database | Any | Java version | ||||||||
| OS Version | Database version | Ant version | ||||||||||
| Product Version | pi | SCM revision | ||||||||||
| Review Assigned To | ||||||||||||
| Web browser | ||||||||||||
| Modules | Core | |||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0007905: Add to validation: module artifacts shouldn't use id's in the range of 100.000-799.999 as these are used for old customizations | |||||||||||
| Description | There is one validation missing: application dictionary components in a module should not use id's in the range of 100.000-799.999. If so they are old customizations and can not be shared through modules because it might cause an id conflict. It should be validated only when packaging the module... | |||||||||||
| Tags | No tags attached. | |||||||||||
| Attached Files | ||||||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0014813) mtaal (manager) 2009-03-20 12:50 |
Design Spec, based on email discussion between Ismael/Martin: The idea is to introduce a new field ad_module.isShareable (nullable, to avoid backward compatibility issues) wich controls if a module is ment to be distributed. Modules which are distributed (isSharable='Y') are not allowed to export custom data (data with an id from 100000 to 799999). The following then applies: ad_module.isshareable=N, results in the following behavior in ant tasks: > export.database of custom objects allowed with warning > export.database will give warnings if there are entries in ad_exception > package.module not allowed ad_module.isshareable=Y, results in the following behavior in ant tasks: > export.database of custom objects not allowed (exception thrown) > export.database is not allowed if there are entries in ad_exception > package.module allowed The above does not apply to core, with the core module all data maybe exported, i.e. the above checks are not needed. |
|
(0021949) alostale (manager) 2009-11-18 09:34 |
The check does not include the id 100.000, it starts in 100.001. Create a field with id 100000 in a module, package it and no error is found. Why is repeating the error several times? (minor issue) I have a field with id 100001 in a module, when packaging it error is raised correctly, but it is shown 3 times: package.module: [echo] Validating Module... [validateModules] 0 [main] ERROR SystemValidation - [validateModules] [validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++ [validateModules] Errors for Validation type: CUSTOMIZATION_ID [validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++ [validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed. [validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed. [validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed. |
|
(0021967) hgbot (developer) 2009-11-18 14:17 |
Repository: erp/devel/pi Changeset: 652e31de84caa6ace3f440276b7baebcb3eddf6d Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Nov 18 14:14:12 2009 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/652e31de84caa6ace3f440276b7baebcb3eddf6d [^] Disabled id check in module validation for now (see issue 7905) --- M src/org/openbravo/service/system/ModuleValidator.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2009-03-03 06:49 | mtaal | New Issue | |
| 2009-03-03 06:49 | mtaal | Assigned To | => mtaal |
| 2009-03-03 06:49 | mtaal | Regression testing | => No |
| 2009-03-04 09:09 | rafaroda | Priority | normal => high |
| 2009-03-04 09:09 | rafaroda | Status | new => scheduled |
| 2009-03-20 12:50 | mtaal | Note Added: 0014813 | |
| 2009-03-20 12:50 | mtaal | Type | defect => feature request |
| 2009-11-10 09:59 | mtaal | Status | scheduled => resolved |
| 2009-11-10 09:59 | mtaal | Fixed in Version | => pi |
| 2009-11-10 09:59 | mtaal | Fixed in SCM revision | => 5391:7c8b073e1826 |
| 2009-11-18 09:34 | alostale | Note Added: 0021949 | |
| 2009-11-18 09:34 | alostale | Status | resolved => new |
| 2009-11-18 09:34 | alostale | Fixed in Version | pi => |
| 2009-11-18 14:17 | hgbot | Checkin | |
| 2009-11-18 14:17 | hgbot | Note Added: 0021967 | |
| 2009-11-18 14:17 | hgbot | Fixed in SCM revision | 5391:7c8b073e1826 => http://code.openbravo.com/erp/devel/pi/rev/652e31de84caa6ace3f440276b7baebcb3eddf6d [^] |
| 2016-10-21 11:06 | mtaal | Status | new => closed |
| 2016-10-21 11:06 | mtaal | Resolution | open => out of date |
| 2016-10-21 13:17 | mtaal | Tag Attached: MT_closed_out_of_date | |
| 2016-10-21 14:08 | mtaal | Assigned To | mtaal => platform |
| 2016-10-21 14:09 | mtaal | Status | closed => new |
| 2016-10-21 14:14 | mtaal | Tag Detached: MT_closed_out_of_date | |
| 2022-02-01 08:09 | alostale | Assigned To | platform => Triage Platform Base |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |