Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0007905Openbravo ERPA. Platformpublic2009-03-03 06:492022-02-01 08:09
mtaal 
Triage Platform Base 
highmajorhave not tried
newout of date 
5
pi 
pi 
Core
No
0007905: Add to validation: module artifacts shouldn't use id's in the range of 100.000-799.999 as these are used for old customizations
There is one validation missing: application dictionary components in
a module should not use id's in the range of 100.000-799.999. If so they are
old customizations and can not be shared through modules because it might
cause an id conflict. It should be validated only when packaging the
module...
No tags attached.
Issue History
2009-03-03 06:49mtaalNew Issue
2009-03-03 06:49mtaalAssigned To => mtaal
2009-03-03 06:49mtaalRegression testing => No
2009-03-04 09:09rafarodaPrioritynormal => high
2009-03-04 09:09rafarodaStatusnew => scheduled
2009-03-20 12:50mtaalNote Added: 0014813
2009-03-20 12:50mtaalTypedefect => feature request
2009-11-10 09:59mtaalStatusscheduled => resolved
2009-11-10 09:59mtaalFixed in Version => pi
2009-11-10 09:59mtaalFixed in SCM revision => 5391:7c8b073e1826
2009-11-18 09:34alostaleNote Added: 0021949
2009-11-18 09:34alostaleStatusresolved => new
2009-11-18 09:34alostaleFixed in Versionpi =>
2009-11-18 14:17hgbotCheckin
2009-11-18 14:17hgbotNote Added: 0021967
2009-11-18 14:17hgbotFixed in SCM revision5391:7c8b073e1826 => http://code.openbravo.com/erp/devel/pi/rev/652e31de84caa6ace3f440276b7baebcb3eddf6d [^]
2016-10-21 11:06mtaalStatusnew => closed
2016-10-21 11:06mtaalResolutionopen => out of date
2016-10-21 13:17mtaalTag Attached: MT_closed_out_of_date
2016-10-21 14:08mtaalAssigned Tomtaal => platform
2016-10-21 14:09mtaalStatusclosed => new
2016-10-21 14:14mtaalTag Detached: MT_closed_out_of_date
2022-02-01 08:09alostaleAssigned Toplatform => Triage Platform Base

Notes
(0014813)
mtaal   
2009-03-20 12:50   
Design Spec, based on email discussion between Ismael/Martin:

The idea is to introduce a new field ad_module.isShareable (nullable, to avoid backward compatibility issues) wich controls if a module is ment to be distributed. Modules which are distributed (isSharable='Y') are not allowed to export custom data (data with an id from 100000 to 799999). The following then applies:

ad_module.isshareable=N, results in the following behavior in ant tasks:
 > export.database of custom objects allowed with warning
 > export.database will give warnings if there are entries in ad_exception
 > package.module not allowed

ad_module.isshareable=Y, results in the following behavior in ant tasks:
 > export.database of custom objects not allowed (exception thrown)
 > export.database is not allowed if there are entries in ad_exception
 > package.module allowed

The above does not apply to core, with the core module all data maybe exported, i.e. the above checks are not needed.
(0021949)
alostale   
2009-11-18 09:34   
The check does not include the id 100.000, it starts in 100.001.

Create a field with id 100000 in a module, package it and no error is found.

Why is repeating the error several times? (minor issue)

I have a field with id 100001 in a module, when packaging it error is raised correctly, but it is shown 3 times:

package.module:
     [echo] Validating Module...
[validateModules] 0 [main] ERROR SystemValidation -
[validateModules]
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Errors for Validation type: CUSTOMIZATION_ID
[validateModules] +++++++++++++++++++++++++++++++++++++++++++++++++++
[validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed.
[validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed.
[validateModules] Module test has an artifact (ADField(100001) (name: f)) with an id in the customization range 100000 to 799999. This is not allowed.
(0021967)
hgbot   
2009-11-18 14:17   
Repository: erp/devel/pi
Changeset: 652e31de84caa6ace3f440276b7baebcb3eddf6d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Nov 18 14:14:12 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/652e31de84caa6ace3f440276b7baebcb3eddf6d [^]

Disabled id check in module validation for now (see issue 7905)

---
M src/org/openbravo/service/system/ModuleValidator.java
---