Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0057989 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [POS2] POS | minor | always | 2025-02-14 10:45 | 2025-02-21 09:18 | |||
| Reporter | NaroaIriarte | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 25Q2 | |||
| Status | resolved | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0057989: The code that validates the CRM configuration properties, should be refectored | |||||||
| Description | Currently, the way of differentiating if a property is from a customer entity or a customer address entity, is checked in several parts of the code of the file 'CustomerFormHandlerUtils'. The way its done, leads to confusion and it is prone to future issues and also it has a high cost in code maintenance. | |||||||
| Steps To Reproduce | Just open the js file and check how many times the check of the entity is done. | |||||||
| Proposed Solution | Refactor the code, take the entity instance to a constant and put it at the beginning. So, all the code will have access to it and the maintenance and the checks will be much easier. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0175773) hgbot (developer) 2025-02-17 14:14 |
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3511 [^] |
|
(0176007) hgbot (developer) 2025-02-21 09:18 |
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f5dc2e1960211b226263e23fbffbfe802bbcf7cd Author: Naroa Iriarte <n.iriarte@orisha.com> Date: 21-02-2025 08:18:28 URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f5dc2e1960211b226263e23fbffbfe802bbcf7cd [^] Fixed ISSUE-57989: Refactor function CustomerFormHandlerUtils.validateWithValidatorEngine --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerUtils/CustomerFormHandlerUtils.js --- |
|
(0176008) hgbot (developer) 2025-02-21 09:18 |
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3511 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2025-02-14 10:45 | NaroaIriarte | New Issue | |
| 2025-02-14 10:45 | NaroaIriarte | Assigned To | => NaroaIriarte |
| 2025-02-14 10:45 | NaroaIriarte | Triggers an Emergency Pack | => No |
| 2025-02-14 10:46 | guillermogil | Type | defect => design defect |
| 2025-02-14 10:50 | NaroaIriarte | Relationship added | related to 0057838 |
| 2025-02-14 10:50 | NaroaIriarte | Status | new => acknowledged |
| 2025-02-14 10:50 | NaroaIriarte | Status | acknowledged => scheduled |
| 2025-02-17 14:14 | hgbot | Note Added: 0175773 | |
| 2025-02-21 09:18 | hgbot | Resolution | open => fixed |
| 2025-02-21 09:18 | hgbot | Status | scheduled => resolved |
| 2025-02-21 09:18 | hgbot | Fixed in Version | => 25Q2 |
| 2025-02-21 09:18 | hgbot | Note Added: 0176007 | |
| 2025-02-21 09:18 | hgbot | Note Added: 0176008 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |