Openbravo Issue Tracking System - POS2
View Issue Details
0057989POS2POSpublic2025-02-14 10:452025-02-21 09:18
NaroaIriarte 
NaroaIriarte 
normalminoralways
resolvedfixed 
5
 
25Q2 
No
0057989: The code that validates the CRM configuration properties, should be refectored
Currently, the way of differentiating if a property is from a customer entity or a customer address entity, is checked in several parts of the code of the file 'CustomerFormHandlerUtils'. The way its done, leads to confusion and it is prone to future issues and also it has a high cost in code maintenance.
Just open the js file and check how many times the check of the entity is done.
Refactor the code, take the entity instance to a constant and put it at the beginning. So, all the code will have access to it and the maintenance and the checks will be much easier.
No tags attached.
related to defect 0057838 closed NaroaIriarte [25Q1] Postal Code Validation Not Applied 
Issue History
2025-02-14 10:45NaroaIriarteNew Issue
2025-02-14 10:45NaroaIriarteAssigned To => NaroaIriarte
2025-02-14 10:45NaroaIriarteTriggers an Emergency Pack => No
2025-02-14 10:46guillermogilTypedefect => design defect
2025-02-14 10:50NaroaIriarteRelationship addedrelated to 0057838
2025-02-14 10:50NaroaIriarteStatusnew => acknowledged
2025-02-14 10:50NaroaIriarteStatusacknowledged => scheduled
2025-02-17 14:14hgbotNote Added: 0175773
2025-02-21 09:18hgbotResolutionopen => fixed
2025-02-21 09:18hgbotStatusscheduled => resolved
2025-02-21 09:18hgbotFixed in Version => 25Q2
2025-02-21 09:18hgbotNote Added: 0176007
2025-02-21 09:18hgbotNote Added: 0176008

Notes
(0175773)
hgbot   
2025-02-17 14:14   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3511 [^]
(0176007)
hgbot   
2025-02-21 09:18   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f5dc2e1960211b226263e23fbffbfe802bbcf7cd
Author: Naroa Iriarte <n.iriarte@orisha.com>
Date: 21-02-2025 08:18:28
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f5dc2e1960211b226263e23fbffbfe802bbcf7cd [^]

Fixed ISSUE-57989: Refactor function CustomerFormHandlerUtils.validateWithValidatorEngine

---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerUtils/CustomerFormHandlerUtils.js
---
(0176008)
hgbot   
2025-02-21 09:18   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3511 [^]