Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0056852

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] Core

major

have not tried

2024-10-21 16:37

2024-12-13 09:30

Reporter

cberner

View Status

public

Assigned To

Triage Platform Base

Priority

normal

Resolution

fixed

Fixed in Version

25Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

cberner

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0056852: Request approval dialog does not show username + password

Description

When in a user-action there are two prehooks, one does show an inputDataDialog, through requestData API, and afterwards, another calls a method that does user action approval, the approval does not show the "username + password" part, it instead shows what was previously shown in the requestData call.

This seems to work fine, if we stop for some seconds between the requestData finishes and the call for approval is done.

Steps To Reproduce

1. Login into POS2 as vallblanca
2. Run the following in Developer Tools - Console:

setTimeout(() => OB.App.View.DialogUIHandler.inputData('OBDISCP_COUPON'), 5000);
await OB.App.View.DialogUIHandler.inputData(
        'OBDISCP_CouponDialog',
        {
          title: '$OBDISCP_RedeemCoupon',
          subTitle: '$OBDISCP_EnterCouponCode',
          variantClass: 'obdiscpCouponDialog',
          properties: {
            fields: [
              {
                name: 'code',
                iconClass: 'obdiscpIconCoupon',
                label: 'Coupon Code',
                variantClass: 'obdiscpCouponDialog-input'
              }
            ]
          },
          hideOk: true,
          extraButtons: [
            {
              name: 'OBDISCP_Redeem',
              label: '$OBDISCP_Redeem',
              icon: 'obc2IconPlus',
              variantClass: 'obdiscpConfirmButton'
            }
          ]
        }
      );

Proposed Solution

Properly clear whatever is in the content of the corresponding BaseDialog, before showing another dialog.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	design defect	0057022		closed	njimenez	Input dialog global component does not support showing twice at the same time
blocks	defect	0056736		closed	guilleaer	Incorrect Approval Dialog Display for Coupons with Extra Validity Days if triggered though Coupons options

Notes
(0172190) guilleaer (viewer) 2024-11-18 17:36	Moved to major because approvals cannot be completed blocking the flow

(0173276) cberner (viewer) 2024-12-13 09:30	It was fixed as part of this issue: https://issues.openbravo.com/view.php?id=57022 [^]

Issue History
Date Modified	Username	Field	Change
2024-10-21 16:37	cberner	New Issue
2024-10-21 16:37	cberner	Assigned To	=> Triage Platform Base
2024-10-21 16:37	cberner	OBNetwork customer	=> No
2024-10-21 16:37	cberner	Triggers an Emergency Pack	=> No
2024-10-21 16:40	guilleaer	Relationship added	blocks 0056736
2024-11-18 17:35	guilleaer	Severity	minor => major
2024-11-18 17:36	guilleaer	Note Added: 0172190
2024-12-11 09:48	AugustoMauch	Status	new => acknowledged
2024-12-11 09:48	AugustoMauch	Assigned To	Triage Platform Base => ablasco
2024-12-13 09:29	cberner	Relationship added	duplicate of 0057022
2024-12-13 09:30	cberner	Status	acknowledged => scheduled
2024-12-13 09:30	cberner	Assigned To	ablasco => Triage Platform Base
2024-12-13 09:30	cberner	Review Assigned To	=> cberner
2024-12-13 09:30	cberner	Note Added: 0173276
2024-12-13 09:30	cberner	Status	scheduled => closed
2024-12-13 09:30	cberner	Resolution	open => fixed
2024-12-13 09:30	cberner	Fixed in Version	=> 25Q1

Copyright © 2000 - 2009 MantisBT Group