Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0056844
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2024-10-21 12:092024-11-05 08:29
ReporteradrianromeroView Statuspublic 
Assigned Toander_flores 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056844: More Swagger spec definition fixes in org.openbravo.api

DescriptionThere are several Swagger (OpenAPI) spec fixes that needs to be reviewed:

* Tax Rate (Import)
Fix "Category" field that it is currently empty it should go to "Master Data"

* Product AUM (Import)
  There is a java property that overwrites this definition "alternativeUnitOfMeasure". The solution should be just remove this mapping with the confirmation of the Retail team who is the owner of this entity. See attached screenshot.

* Define strategy for fixing swagger validation issues in other API modules owned by other teams


* Good to do: Define and document tool to validate swagger 3.1.0 version files
for example: https://github.com/Redocly/redocly-cli [^] or https://github.com/stoplightio/spectral [^]

In case of redocly:
-> % npm install @redocly/openapi-cli
-> % node_modules/@redocly/openapi-cli/bin/cli.js lint --max-problems 10000 ~/business-api-master-data.json
Steps To ReproduceRun swagger validation 3.1.0 version for generated and manual spec files
TagsNo tags attached.
Attached Filespng file icon productaum.png [^] (570,873 bytes) 2024-10-21 12:17

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0056613 closedadrianromero Swagger spec definition fixes in org.openbravo.api 
related to defect 0056915 closedander_flores Fix validation errors in .yml files for Swagger spec files 

-  Notes
(0170870)
hgbot (developer)
2024-10-24 08:32

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/351 [^]
(0170941)
hgbot (developer)
2024-10-25 09:52

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.purchase.api/-/merge_requests/8 [^]
(0171088)
hgbot (developer)
2024-10-29 09:56

Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.purchase.api/-/merge_requests/8 [^]
(0171375)
hgbot (developer)
2024-11-05 08:29

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/351 [^]
(0171376)
hgbot (developer)
2024-11-05 08:29

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 233abb44e1878fb6b0b26f31ee5da6bf53ecceba
Author: Ander Flores <a.flores@orisha.com>
Date: 05-11-2024 07:29:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/233abb44e1878fb6b0b26f31ee5da6bf53ecceba [^]

Fixed ISSUE-56844: More Swagger spec definition fixes in org.openbravo.api

---
M src-db/database/sourcedata/OBEI_ENTITY_MAPPING.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---

- Issue History
Date Modified Username Field Change
2024-10-21 12:09 adrianromero New Issue
2024-10-21 12:09 adrianromero Assigned To => Triage Platform Conn
2024-10-21 12:09 adrianromero Triggers an Emergency Pack => No
2024-10-21 12:09 adrianromero Issue generated from 0056613
2024-10-21 12:09 adrianromero Relationship added related to 0056613
2024-10-21 12:15 adrianromero Description Updated View Revisions
2024-10-21 12:16 adrianromero Description Updated View Revisions
2024-10-21 12:17 adrianromero File Added: productaum.png
2024-10-21 12:17 adrianromero Status new => acknowledged
2024-10-21 12:26 adrianromero Assigned To Triage Platform Conn => ander_flores
2024-10-24 08:32 hgbot Note Added: 0170870
2024-10-25 09:52 hgbot Note Added: 0170941
2024-10-28 12:12 ander_flores Relationship added related to 0056915
2024-10-29 09:56 hgbot Note Added: 0171088
2024-11-05 08:29 hgbot Note Added: 0171375
2024-11-05 08:29 hgbot Resolution open => fixed
2024-11-05 08:29 hgbot Status acknowledged => closed
2024-11-05 08:29 hgbot Note Added: 0171376


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker