Openbravo Issue Tracking System - Retail Modules
View Issue Details
0056844Retail ModulesWeb POSpublic2024-10-21 12:092024-11-05 08:29
adrianromero 
ander_flores 
normalmajorhave not tried
closedfixed 
5
 
 
No
0056844: More Swagger spec definition fixes in org.openbravo.api
There are several Swagger (OpenAPI) spec fixes that needs to be reviewed:

* Tax Rate (Import)
Fix "Category" field that it is currently empty it should go to "Master Data"

* Product AUM (Import)
  There is a java property that overwrites this definition "alternativeUnitOfMeasure". The solution should be just remove this mapping with the confirmation of the Retail team who is the owner of this entity. See attached screenshot.

* Define strategy for fixing swagger validation issues in other API modules owned by other teams


* Good to do: Define and document tool to validate swagger 3.1.0 version files
for example: https://github.com/Redocly/redocly-cli [^] or https://github.com/stoplightio/spectral [^]

In case of redocly:
-> % npm install @redocly/openapi-cli
-> % node_modules/@redocly/openapi-cli/bin/cli.js lint --max-problems 10000 ~/business-api-master-data.json
Run swagger validation 3.1.0 version for generated and manual spec files
No tags attached.
related to defect 0056613 closed adrianromero Swagger spec definition fixes in org.openbravo.api 
related to defect 0056915 closed ander_flores Fix validation errors in .yml files for Swagger spec files 
png productaum.png (570,873) 2024-10-21 12:17
https://issues.openbravo.com/file_download.php?file_id=20346&type=bug
Issue History
2024-10-21 12:09adrianromeroNew Issue
2024-10-21 12:09adrianromeroAssigned To => Triage Platform Conn
2024-10-21 12:09adrianromeroTriggers an Emergency Pack => No
2024-10-21 12:09adrianromeroIssue generated from0056613
2024-10-21 12:09adrianromeroRelationship addedrelated to 0056613
2024-10-21 12:15adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=28630#r28630
2024-10-21 12:16adrianromeroDescription Updatedbug_revision_view_page.php?rev_id=28631#r28631
2024-10-21 12:17adrianromeroFile Added: productaum.png
2024-10-21 12:17adrianromeroStatusnew => acknowledged
2024-10-21 12:26adrianromeroAssigned ToTriage Platform Conn => ander_flores
2024-10-24 08:32hgbotNote Added: 0170870
2024-10-25 09:52hgbotNote Added: 0170941
2024-10-28 12:12ander_floresRelationship addedrelated to 0056915
2024-10-29 09:56hgbotNote Added: 0171088
2024-11-05 08:29hgbotNote Added: 0171375
2024-11-05 08:29hgbotResolutionopen => fixed
2024-11-05 08:29hgbotStatusacknowledged => closed
2024-11-05 08:29hgbotNote Added: 0171376

Notes
(0170870)
hgbot   
2024-10-24 08:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/351 [^]
(0170941)
hgbot   
2024-10-25 09:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.purchase.api/-/merge_requests/8 [^]
(0171088)
hgbot   
2024-10-29 09:56   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.purchase.api/-/merge_requests/8 [^]
(0171375)
hgbot   
2024-11-05 08:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/351 [^]
(0171376)
hgbot   
2024-11-05 08:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: 233abb44e1878fb6b0b26f31ee5da6bf53ecceba
Author: Ander Flores <a.flores@orisha.com>
Date: 05-11-2024 07:29:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/233abb44e1878fb6b0b26f31ee5da6bf53ecceba [^]

Fixed ISSUE-56844: More Swagger spec definition fixes in org.openbravo.api

---
M src-db/database/sourcedata/OBEI_ENTITY_MAPPING.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---