Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0056150 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Retail API | major | always | 2024-08-01 14:39 | 2024-08-08 07:44 | |||
| Reporter | kchoperena | View Status | public | |||||
| Assigned To | Retail | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0056150: Import of ProductPriceException API documentation is broken | |||||||
| Description | The class ImportProductPriceExceptionJavaPropertyMappingHandler is overriding the getPropertyDocumentation hiding all the documentation included in the super class | |||||||
| Steps To Reproduce | 1.- Log into the Openbravo backoffice 2.- Open the Swagger and check the schema for the import of the PriceList RESULT: Inside the PriceListVersion > ProductPrice > ProductPriceException, the organization field is missing | |||||||
| Proposed Solution | diff --git a/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java b/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java index 1e3878c..d94e1df 100644 --- a/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java +++ b/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java @@ -44,8 +44,8 @@ public class ImportProductPriceExceptionJavaPropertyMappingHandler @Override public List<PropertyDocumentation<?>> getPropertyDocumentation() { - return List.of(new StringPropertyDocumentation(PROPERTY_COMMERCIAL_OPERATION).nullable(true) - .description("To add a commercial operation to the price exception")); + return combinePropertyDocumentation(super.getPropertyDocumentation(),List.of(new StringPropertyDocumentation(PROPERTY_COMMERCIAL_OPERATION).nullable(true) + .description("To add a commercial operation to the price exception"))); } @Override | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Screenshot from 2024-08-01 14-38-35.png [^] (92,737 bytes) 2024-08-01 14:39
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0167613) hgbot (developer) 2024-08-01 14:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/merge_requests/16 [^] |
|
(0167824) hgbot (developer) 2024-08-08 07:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/merge_requests/16 [^] |
|
(0167825) hgbot (developer) 2024-08-08 07:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api [^] Changeset: d12f9bfb4404f49aac1d77d254dac6cbff628265 Author: Kepa Choperena <kepa.choperena@openbravo.com> Date: 01-08-2024 14:52:24 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/commit/d12f9bfb4404f49aac1d77d254dac6cbff628265 [^] Fixes ISSUE-56150: Combined the documentation of the swagger with the super class in Import ProductPriceException --- M src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-08-01 14:39 | kchoperena | New Issue | |
| 2024-08-01 14:39 | kchoperena | Assigned To | => Triage Platform Conn |
| 2024-08-01 14:39 | kchoperena | File Added: Screenshot from 2024-08-01 14-38-35.png | |
| 2024-08-01 14:39 | kchoperena | Triggers an Emergency Pack | => No |
| 2024-08-01 14:40 | kchoperena | Proposed Solution updated | |
| 2024-08-01 14:54 | hgbot | Note Added: 0167613 | |
| 2024-08-01 15:07 | adrianromero | Assigned To | Triage Platform Conn => Retail |
| 2024-08-08 07:44 | hgbot | Note Added: 0167824 | |
| 2024-08-08 07:44 | hgbot | Resolution | open => fixed |
| 2024-08-08 07:44 | hgbot | Status | new => closed |
| 2024-08-08 07:44 | hgbot | Note Added: 0167825 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |