Openbravo Issue Tracking System - Retail Modules
View Issue Details
0056150Retail ModulesRetail APIpublic2024-08-01 14:392024-08-08 07:44
kchoperena 
Retail 
highmajoralways
closedfixed 
5
 
 
No
0056150: Import of ProductPriceException API documentation is broken
The class ImportProductPriceExceptionJavaPropertyMappingHandler is overriding the getPropertyDocumentation hiding all the documentation included in the super class
1.- Log into the Openbravo backoffice
2.- Open the Swagger and check the schema for the import of the PriceList

RESULT: Inside the PriceListVersion > ProductPrice > ProductPriceException, the organization field is missing
diff --git a/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java b/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java
index 1e3878c..d94e1df 100644
--- a/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java
+++ b/src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java
@@ -44,8 +44,8 @@ public class ImportProductPriceExceptionJavaPropertyMappingHandler
 
   @Override
   public List<PropertyDocumentation<?>> getPropertyDocumentation() {
- return List.of(new StringPropertyDocumentation(PROPERTY_COMMERCIAL_OPERATION).nullable(true)
- .description("To add a commercial operation to the price exception"));
+ return combinePropertyDocumentation(super.getPropertyDocumentation(),List.of(new StringPropertyDocumentation(PROPERTY_COMMERCIAL_OPERATION).nullable(true)
+ .description("To add a commercial operation to the price exception")));
   }
 
   @Override
No tags attached.
png Screenshot from 2024-08-01 14-38-35.png (92,737) 2024-08-01 14:39
https://issues.openbravo.com/file_download.php?file_id=20053&type=bug
png
Issue History
2024-08-01 14:39kchoperenaNew Issue
2024-08-01 14:39kchoperenaAssigned To => Triage Platform Conn
2024-08-01 14:39kchoperenaFile Added: Screenshot from 2024-08-01 14-38-35.png
2024-08-01 14:39kchoperenaTriggers an Emergency Pack => No
2024-08-01 14:40kchoperenaProposed Solution updated
2024-08-01 14:54hgbotNote Added: 0167613
2024-08-01 15:07adrianromeroAssigned ToTriage Platform Conn => Retail
2024-08-08 07:44hgbotNote Added: 0167824
2024-08-08 07:44hgbotResolutionopen => fixed
2024-08-08 07:44hgbotStatusnew => closed
2024-08-08 07:44hgbotNote Added: 0167825

Notes
(0167613)
hgbot   
2024-08-01 14:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/merge_requests/16 [^]
(0167824)
hgbot   
2024-08-08 07:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/merge_requests/16 [^]
(0167825)
hgbot   
2024-08-08 07:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api [^]
Changeset: d12f9bfb4404f49aac1d77d254dac6cbff628265
Author: Kepa Choperena <kepa.choperena@openbravo.com>
Date: 01-08-2024 14:52:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.commercialoperations.api/-/commit/d12f9bfb4404f49aac1d77d254dac6cbff628265 [^]

Fixes ISSUE-56150: Combined the documentation of the swagger with the super class in Import ProductPriceException

---
M src/org/openbravo/commercialoperations/api/mappings/ProductPriceException/ImportProductPriceExceptionJavaPropertyMappingHandler.java
---