Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0056070
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2024-07-19 11:542024-07-22 11:57
ReportermigueldejuanaView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version24Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0056070: When sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated

DescriptionWhen sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated.

In case we lose the value of state.DocumentSequence.lastassignednum.sequenceNumber we get the information from terminal but this info is not always up to date.
Steps To Reproduce- Login in POS2
- Create 3 orders and confirm the DocNo in Sales Order window in the ERP (i.e.: 001, 002 and 003)
- Put a breakpoint in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/ob-init.js#L3309 [^]
- Set to undefined the sequenceNumber (state.DocumentSequence.lastassignednum.sequenceNumber = undefined;)
- Put a breakpoint in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js#L141 [^]
- Resume the first breakpoint
- Check in the second breakpoint that "Terminal.terminal.lastDocumentNumber" is not "3" as expected.
- Resume the second breakpoint
- DO a sale a confirm that the DocNo of this order is duplicated ("001")
Proposed SolutionIf state.DocumentSequence.lastassignednum.sequenceNumber is undefined in initializeDocumentSequence, we should do a request to the backend to get that information instead of getting "Terminal.terminal.lastDocumentNumber".

Check this code that could be useful: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/src/org/openbravo/retail/posterminal/term/Terminal.java#L85 [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0056246 closedsreehari Implement second Mitigation for duplicating document sequence number 

-  Notes
(0167210)
hgbot (developer)
2024-07-22 08:47

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2811 [^]
(0167218)
hgbot (developer)
2024-07-22 11:57

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2811 [^]
(0167219)
hgbot (developer)
2024-07-22 11:57

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3b98aafeeaa3a836d09bf8f5bc66c5be4879afeb
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 19-07-2024 18:54:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3b98aafeeaa3a836d09bf8f5bc66c5be4879afeb [^]

Fixes ISSUE-56070: loadTerminalData when DocumentSequence is undefined

---
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
---

- Issue History
Date Modified Username Field Change
2024-07-19 11:54 migueldejuana New Issue
2024-07-19 11:54 migueldejuana Assigned To => Retail
2024-07-19 11:54 migueldejuana Triggers an Emergency Pack => No
2024-07-19 12:04 sreehari Assigned To Retail => sreehari
2024-07-19 12:04 sreehari Status new => scheduled
2024-07-22 08:47 hgbot Note Added: 0167210
2024-07-22 11:57 hgbot Note Added: 0167218
2024-07-22 11:57 hgbot Resolution open => fixed
2024-07-22 11:57 hgbot Status scheduled => closed
2024-07-22 11:57 hgbot Fixed in Version => 24Q4
2024-07-22 11:57 hgbot Note Added: 0167219
2024-08-13 07:14 sreehari Relationship added related to 0056246


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker