0056070: When sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0056070

POS2

POS

public

2024-07-19 11:54

2024-07-22 11:57

Reporter

migueldejuana

Assigned To

sreehari

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

24Q4

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0056070: When sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated

Description

When sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated.

In case we lose the value of state.DocumentSequence.lastassignednum.sequenceNumber we get the information from terminal but this info is not always up to date.

Steps To Reproduce

- Login in POS2
- Create 3 orders and confirm the DocNo in Sales Order window in the ERP (i.e.: 001, 002 and 003)
- Put a breakpoint in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/ob-init.js#L3309 [^]
- Set to undefined the sequenceNumber (state.DocumentSequence.lastassignednum.sequenceNumber = undefined;)
- Put a breakpoint in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js#L141 [^]
- Resume the first breakpoint
- Check in the second breakpoint that "Terminal.terminal.lastDocumentNumber" is not "3" as expected.
- Resume the second breakpoint
- DO a sale a confirm that the DocNo of this order is duplicated ("001")

Proposed Solution

If state.DocumentSequence.lastassignednum.sequenceNumber is undefined in initializeDocumentSequence, we should do a request to the backend to get that information instead of getting "Terminal.terminal.lastDocumentNumber".

Check this code that could be useful: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/src/org/openbravo/retail/posterminal/term/Terminal.java#L85 [^]

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0056246		closed	sreehari	Implement second Mitigation for duplicating document sequence number
causes	defect	0057253		closed	sreehari	Not possible to login to the POS with the offline mode