Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053659
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2023-10-13 14:462023-10-16 07:34
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053659: Delete 2 junit tets (which are rather old SQL->HQL translation examples)

DescriptionThose 2 very old junit tests

https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/test/dal/DalComplexQueryRequisitionTest.java?ref_type=heads [^]
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/test/dal/DalComplexQueryTestOrderLine.java?ref_type=heads [^]

are not really testing anything but are rather code-examples related to 2 wiki HowTo pages:

http://wiki.openbravo.com/wiki/How_to_do_a_complex_query_using_the_DAL-1 [^]
http://wiki.openbravo.com/wiki/How_to_do_a_complex_query_using_the_DAL-2 [^]

Additionally they have not been updated to latest coding style (i.e. our HQL style) so are not great example on how to write HQL today.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0155836)
hgbot (developer)
2023-10-13 14:51

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1019 [^]
(0155844)
hgbot (developer)
2023-10-16 07:34

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1019 [^]
(0155845)
hgbot (developer)
2023-10-16 07:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6fa6abf024c898d556e876d15bef7e09c015eef3
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 13-10-2023 14:49:03
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6fa6abf024c898d556e876d15bef7e09c015eef3 [^]

Fixes ISSUE-53659: Remove 2 ancient dal junit tests

Those 2 test classes did not really test anything. But were rather code
example on how to convert some non-trivial SQL query piece by piece to
HQL.

That is more a documentation topic and both Howto's are still present
on the wiki).
Additionally those code-examples where not updated i.e. with HQL style
so are no best practice to use as is.

Remove the 2 unit tests classes.

---
M src-test/src/org/openbravo/test/StandaloneTestSuite.java
R src-test/src/org/openbravo/test/dal/DalComplexQueryRequisitionTest.java
R src-test/src/org/openbravo/test/dal/DalComplexQueryTestOrderLine.java
---

- Issue History
Date Modified Username Field Change
2023-10-13 14:46 shuehner New Issue
2023-10-13 14:46 shuehner Assigned To => shuehner
2023-10-13 14:46 shuehner OBNetwork customer => No
2023-10-13 14:46 shuehner Modules => Core
2023-10-13 14:46 shuehner Triggers an Emergency Pack => No
2023-10-13 14:51 hgbot Merge Request Status => open
2023-10-13 14:51 hgbot Note Added: 0155836
2023-10-16 07:34 hgbot Merge Request Status open => approved
2023-10-16 07:34 hgbot Resolution open => fixed
2023-10-16 07:34 hgbot Status new => closed
2023-10-16 07:34 hgbot Fixed in Version => PR24Q1
2023-10-16 07:34 hgbot Note Added: 0155844
2023-10-16 07:34 hgbot Note Added: 0155845

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker