Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053659Openbravo ERPA. Platformpublic2023-10-13 14:462023-10-16 07:34
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR24Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053659: Delete 2 junit tets (which are rather old SQL->HQL translation examples)
DescriptionThose 2 very old junit tests

https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/test/dal/DalComplexQueryRequisitionTest.java?ref_type=heads [^]
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-test/src/org/openbravo/test/dal/DalComplexQueryTestOrderLine.java?ref_type=heads [^]

are not really testing anything but are rather code-examples related to 2 wiki HowTo pages:

http://wiki.openbravo.com/wiki/How_to_do_a_complex_query_using_the_DAL-1 [^]
http://wiki.openbravo.com/wiki/How_to_do_a_complex_query_using_the_DAL-2 [^]

Additionally they have not been updated to latest coding style (i.e. our HQL style) so are not great example on how to write HQL today.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-10-13 14:46shuehnerNew Issue
2023-10-13 14:46shuehnerAssigned To => shuehner
2023-10-13 14:46shuehnerOBNetwork customer => No
2023-10-13 14:46shuehnerModules => Core
2023-10-13 14:46shuehnerTriggers an Emergency Pack => No
2023-10-13 14:51hgbotMerge Request Status => open
2023-10-13 14:51hgbotNote Added: 0155836
2023-10-16 07:34hgbotMerge Request Statusopen => approved
2023-10-16 07:34hgbotResolutionopen => fixed
2023-10-16 07:34hgbotStatusnew => closed
2023-10-16 07:34hgbotFixed in Version => PR24Q1
2023-10-16 07:34hgbotNote Added: 0155844
2023-10-16 07:34hgbotNote Added: 0155845

Notes
(0155836)
hgbot   
2023-10-13 14:51   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1019 [^]
(0155844)
hgbot   
2023-10-16 07:34   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1019 [^]
(0155845)
hgbot   
2023-10-16 07:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6fa6abf024c898d556e876d15bef7e09c015eef3
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 13-10-2023 14:49:03
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6fa6abf024c898d556e876d15bef7e09c015eef3 [^]

Fixes ISSUE-53659: Remove 2 ancient dal junit tests

Those 2 test classes did not really test anything. But were rather code
example on how to convert some non-trivial SQL query piece by piece to
HQL.

That is more a documentation topic and both Howto's are still present
on the wiki).
Additionally those code-examples where not updated i.e. with HQL style
so are no best practice to use as is.

Remove the 2 unit tests classes.

---
M src-test/src/org/openbravo/test/StandaloneTestSuite.java
R src-test/src/org/openbravo/test/dal/DalComplexQueryRequisitionTest.java
R src-test/src/org/openbravo/test/dal/DalComplexQueryTestOrderLine.java
---