Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053568
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2023-09-29 10:002023-10-02 10:34
ReporternjimenezView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in Version23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053568: When a confirm dialog is intended to be shown while ticket confirmation a javascript error is shown instead

DescriptionThere is a javascript error message shown while processing a ticket in case an error is tried to be shown in a confirmation message instead of processing the ticket.

The error message sais rollback is not a function.

The problem is that there is defined an action preparation whose second parameters is a integer instead of a function.

The action preparation is in line 278 and it is called checkBusinessPartnerIsAvailable.

It has been added in the following commit:

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4c7afb34430de9b79643b5c9dc61b49e098444de [^]
Steps To Reproduce1. Login in the POS application
2. Create a ticket
3. Add products and payments
4. Make a functional flow that will make a complete ticket action preparation to cancel the state action
5. Complete the ticket

See an error message telling the user that rollback is not a function
Proposed SolutionThere is a diff atached to the issue showing the fix
TagsNo tags attached.
Attached Filesdiff file icon rollbackError.diff [^] (813 bytes) 2023-09-29 10:00 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0155387)
hgbot (developer)
2023-09-29 13:47

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2131 [^]
(0155397)
hgbot (developer)
2023-10-02 10:34

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2131 [^]
(0155398)
hgbot (developer)
2023-10-02 10:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 602c4acdaba1db5948427cc1035236197a2ff0ba
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 02-10-2023 08:34:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/602c4acdaba1db5948427cc1035236197a2ff0ba [^]

Fixes ISSUE-53568: When a confirm dialog is intended to be shown while ticket confirmation a javascript error is shown instead
-Removed explicit priority in TicketExtension.js, OB.App.StateAPI.Global.completeTicket.addActionPreparation(
    checkBusinessPartnerIsAvailable
  );

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---

- Issue History
Date Modified Username Field Change
2023-09-29 10:00 njimenez New Issue
2023-09-29 10:00 njimenez Assigned To => Retail
2023-09-29 10:00 njimenez File Added: rollbackError.diff
2023-09-29 10:00 njimenez OBNetwork customer => No
2023-09-29 10:00 njimenez Triggers an Emergency Pack => No
2023-09-29 13:47 hgbot Merge Request Status => open
2023-09-29 13:47 hgbot Note Added: 0155387
2023-10-02 10:34 hgbot Merge Request Status open => approved
2023-10-02 10:34 hgbot Resolution open => fixed
2023-10-02 10:34 hgbot Status new => closed
2023-10-02 10:34 hgbot Note Added: 0155397
2023-10-02 10:34 hgbot Fixed in Version => 23Q4
2023-10-02 10:34 hgbot Note Added: 0155398

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker