Openbravo Issue Tracking System - POS2
View Issue Details
0053568POS2POSpublic2023-09-29 10:002023-10-02 10:34
njimenez 
Retail 
normalmajorhave not tried
closedfixed 
5
 
23Q4 
No
0053568: When a confirm dialog is intended to be shown while ticket confirmation a javascript error is shown instead
There is a javascript error message shown while processing a ticket in case an error is tried to be shown in a confirmation message instead of processing the ticket.

The error message sais rollback is not a function.

The problem is that there is defined an action preparation whose second parameters is a integer instead of a function.

The action preparation is in line 278 and it is called checkBusinessPartnerIsAvailable.

It has been added in the following commit:

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4c7afb34430de9b79643b5c9dc61b49e098444de [^]
1. Login in the POS application
2. Create a ticket
3. Add products and payments
4. Make a functional flow that will make a complete ticket action preparation to cancel the state action
5. Complete the ticket

See an error message telling the user that rollback is not a function
There is a diff atached to the issue showing the fix
No tags attached.
diff rollbackError.diff (813) 2023-09-29 10:00
https://issues.openbravo.com/file_download.php?file_id=19001&type=bug
Issue History
2023-09-29 10:00njimenezNew Issue
2023-09-29 10:00njimenezAssigned To => Retail
2023-09-29 10:00njimenezFile Added: rollbackError.diff
2023-09-29 10:00njimenezTriggers an Emergency Pack => No
2023-09-29 13:47hgbotNote Added: 0155387
2023-10-02 10:34hgbotResolutionopen => fixed
2023-10-02 10:34hgbotStatusnew => closed
2023-10-02 10:34hgbotNote Added: 0155397
2023-10-02 10:34hgbotFixed in Version => 23Q4
2023-10-02 10:34hgbotNote Added: 0155398

Notes
(0155387)
hgbot   
2023-09-29 13:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2131 [^]
(0155397)
hgbot   
2023-10-02 10:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2131 [^]
(0155398)
hgbot   
2023-10-02 10:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 602c4acdaba1db5948427cc1035236197a2ff0ba
Author: Justin Patterson <justin.patterson@openbravo.com>
Date: 02-10-2023 08:34:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/602c4acdaba1db5948427cc1035236197a2ff0ba [^]

Fixes ISSUE-53568: When a confirm dialog is intended to be shown while ticket confirmation a javascript error is shown instead
-Removed explicit priority in TicketExtension.js, OB.App.StateAPI.Global.completeTicket.addActionPreparation(
    checkBusinessPartnerIsAvailable
  );

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---