Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053212 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | minor | have not tried | 2023-08-14 08:44 | 2023-08-14 08:57 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | ablasco | |||||||
| Priority | normal | Resolution | no change required | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053212: CSS classes to specify the current theme and theme mode are included in too many components, should be ThemeProvider only | |||||||
| Description | The ThemeProvider component [1] is the one responsible for setting the classes related to the current theme and theme mode, with the intention of it being a wrapper over the rest of components. But there are many other components (see [2], [3], [4]) that are including also some of that information, and as a consequence they are hardcoded to dark-mode. This classes should be included in a single place (ThemeProvider), and done in a way that makes it unnecessary to include them in other components. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/ThemeProvider/ThemeProvider.jsx [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx [^] [3] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/ErrorScreen/ErrorScreen.jsx [^] [4] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseTooltip/BaseTooltip.jsx [^] | |||||||
| Steps To Reproduce | See code mentioned above. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0153469) AugustoMauch (administrator) 2023-08-14 08:57 |
Will be fixed as part of 53175 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-08-14 08:44 | AugustoMauch | New Issue | |
| 2023-08-14 08:44 | AugustoMauch | Assigned To | => Triage Platform Base |
| 2023-08-14 08:44 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2023-08-14 08:45 | AugustoMauch | Assigned To | Triage Platform Base => ablasco |
| 2023-08-14 08:45 | AugustoMauch | Status | new => scheduled |
| 2023-08-14 08:57 | AugustoMauch | Note Added: 0153469 | |
| 2023-08-14 08:57 | AugustoMauch | Status | scheduled => closed |
| 2023-08-14 08:57 | AugustoMauch | Resolution | open => no change required |
| 2023-08-14 08:57 | AugustoMauch | Relationship added | related to 0053175 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |