Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053212POS2Corepublic2023-08-14 08:442023-08-14 08:57
ReporterAugustoMauch 
Assigned Toablasco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053212: CSS classes to specify the current theme and theme mode are included in too many components, should be ThemeProvider only
DescriptionThe ThemeProvider component [1] is the one responsible for setting the classes related to the current theme and theme mode, with the intention of it being a wrapper over the rest of components.

But there are many other components (see [2], [3], [4]) that are including also some of that information, and as a consequence they are hardcoded to dark-mode. This classes should be included in a single place (ThemeProvider), and done in a way that makes it unnecessary to include them in other components.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/ThemeProvider/ThemeProvider.jsx [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx [^]
[3] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/ErrorScreen/ErrorScreen.jsx [^]
[4] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseTooltip/BaseTooltip.jsx [^]
Steps To ReproduceSee code mentioned above.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0053175 closed meriem_azaf [React POS] Toggle between Dark and Light Theme 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-14 08:44AugustoMauchNew Issue
2023-08-14 08:44AugustoMauchAssigned To => Triage Platform Base
2023-08-14 08:44AugustoMauchTriggers an Emergency Pack => No
2023-08-14 08:45AugustoMauchAssigned ToTriage Platform Base => ablasco
2023-08-14 08:45AugustoMauchStatusnew => scheduled
2023-08-14 08:57AugustoMauchNote Added: 0153469
2023-08-14 08:57AugustoMauchStatusscheduled => closed
2023-08-14 08:57AugustoMauchResolutionopen => no change required
2023-08-14 08:57AugustoMauchRelationship addedrelated to 0053175

Notes
(0153469)
AugustoMauch   
2023-08-14 08:57   
Will be fixed as part of 53175