Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052983

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2023-07-17 16:35

2023-07-27 08:56

Reporter

shuehner

View Status

public

Assigned To

shuehner

Priority

normal

Resolution

fixed

Fixed in Version

PR23Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052983: Remove unused/obsolete 2.50 style alert code from VerticalMenu

Description

VerticalMenu.html still contains chunk of code related to old 2.50 style alerting.

In 2.50 a period 50s timer was setup in that file to call the backend to check if new Alerts are present.

That is long obsolete and the server-side code was removed in 2017 here
https://gitlab.com/openbravo/product/openbravo/-/commit/e59ab256267daccf41a96e21cbda151f88dd2ce2 [^]

The frontend code is still present and would be used if hideMenu=false param was passed.
It can't work anymore with both the removed backend code + the domElement alertCount gone.

Steps To Reproduce

-

Proposed Solution

Delete the obsolete client side code.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0152566) hgbot (developer) 2023-07-17 16:42	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/945 [^]

(0152903) hgbot (developer) 2023-07-27 08:56	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/945 [^]

(0152904) hgbot (developer) 2023-07-27 08:56	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 6ff0d1d354264eab23b64b66a451699ba9da4f77 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 26-07-2023 07:23:03 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6ff0d1d354264eab23b64b66a451699ba9da4f77 [^] Fixes ISSUE-52983: Remove obsolete 2.50 style alerting frontend code. - In old 2.50 major version VerticalMenu set up a 50s timer to periodically check the backend for new alerts. - That is runtime switched-off using isWindowInMDIContext already. - The server side code was already removed in 2017. This finishes that cleanup removing the unused client side code. --- M src/org/openbravo/erpCommon/utility/VerticalMenu.html M web/js/appStatus.js ---

Issue History
Date Modified	Username	Field	Change
2023-07-17 16:35	shuehner	New Issue
2023-07-17 16:35	shuehner	Assigned To	=> shuehner
2023-07-17 16:35	shuehner	OBNetwork customer	=> No
2023-07-17 16:35	shuehner	Modules	=> Core
2023-07-17 16:35	shuehner	Triggers an Emergency Pack	=> No
2023-07-17 16:42	hgbot	Merge Request Status	=> open
2023-07-17 16:42	hgbot	Note Added: 0152566
2023-07-27 08:56	hgbot	Merge Request Status	open => approved
2023-07-27 08:56	hgbot	Resolution	open => fixed
2023-07-27 08:56	hgbot	Status	new => closed
2023-07-27 08:56	hgbot	Note Added: 0152903
2023-07-27 08:56	hgbot	Fixed in Version	=> PR23Q4
2023-07-27 08:56	hgbot	Note Added: 0152904

Copyright © 2000 - 2009 MantisBT Group