Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0052983Openbravo ERPA. Platformpublic2023-07-17 16:352023-07-27 08:56
shuehner 
shuehner 
normalminorhave not tried
closedfixed 
5
 
PR23Q4 
approved
No
Core
No
0052983: Remove unused/obsolete 2.50 style alert code from VerticalMenu
VerticalMenu.html still contains chunk of code related to old 2.50 style alerting.

In 2.50 a period 50s timer was setup in that file to call the backend to check if new Alerts are present.

That is long obsolete and the server-side code was removed in 2017 here
https://gitlab.com/openbravo/product/openbravo/-/commit/e59ab256267daccf41a96e21cbda151f88dd2ce2 [^]

The frontend code is still present and would be used if hideMenu=false param was passed.
It can't work anymore with both the removed backend code + the domElement alertCount gone.
-
Delete the obsolete client side code.
No tags attached.
Issue History
2023-07-17 16:35shuehnerNew Issue
2023-07-17 16:35shuehnerAssigned To => shuehner
2023-07-17 16:35shuehnerOBNetwork customer => No
2023-07-17 16:35shuehnerModules => Core
2023-07-17 16:35shuehnerTriggers an Emergency Pack => No
2023-07-17 16:42hgbotMerge Request Status => open
2023-07-17 16:42hgbotNote Added: 0152566
2023-07-27 08:56hgbotMerge Request Statusopen => approved
2023-07-27 08:56hgbotResolutionopen => fixed
2023-07-27 08:56hgbotStatusnew => closed
2023-07-27 08:56hgbotNote Added: 0152903
2023-07-27 08:56hgbotFixed in Version => PR23Q4
2023-07-27 08:56hgbotNote Added: 0152904

Notes
(0152566)
hgbot   
2023-07-17 16:42   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/945 [^]
(0152903)
hgbot   
2023-07-27 08:56   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/945 [^]
(0152904)
hgbot   
2023-07-27 08:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 6ff0d1d354264eab23b64b66a451699ba9da4f77
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 26-07-2023 07:23:03
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6ff0d1d354264eab23b64b66a451699ba9da4f77 [^]

Fixes ISSUE-52983: Remove obsolete 2.50 style alerting frontend code.

- In old 2.50 major version VerticalMenu set up a 50s timer to
  periodically check the backend for new alerts.
- That is runtime switched-off using isWindowInMDIContext already.
- The server side code was already removed in 2017.

This finishes that cleanup removing the unused client side code.

---
M src/org/openbravo/erpCommon/utility/VerticalMenu.html
M web/js/appStatus.js
---