Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052802

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

major

have not tried

2023-06-20 17:48

2023-06-21 17:34

Reporter

caristu

View Status

public

Assigned To

ablasco

Priority

high

Resolution

fixed

Fixed in Version

23Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052802: Customer form layout is broken when displaying a message

Description

Customer form layout is broken when displaying a message: the buttons in the bottom are cropped

Steps To Reproduce

0) Apply the attached patch in org.openbravo.pos2 module which forces a message appear in the customer form

Option 1:
1) Click on the ticket business partner button and search for a business partner
2) Select one business partner to assign it to the ticket
3) Click again on the business partner button and select the "View Info" menu option. The customer form is opened with the info but the buttons in the bottom are cropped.

Option 2:
1) Click on the ticket business partner button and search for a business partner
2) Click on the create new button
3) The customer form is opened in edit view but the buttons in the bottom are cropped

Proposed Solution

Removing grid-template-rows from this style[1] seems to fix the problem, but need to be tested because I'm not sure if it could break any other thing.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss#L72 [^]

Tags

No tags attached.

Selection_152.png [^] (23,806 bytes) 2023-06-20 17:48

forceMessage.diff [^] (722 bytes) 2023-06-20 17:59 [Show Content] [Hide Content]

diff --git a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
index 542b5ae01..996d3175e 100644
--- a/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
+++ b/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormHandler.js
@@ -68,7 +68,8 @@ class CustomerFormHandler extends FormHandler {
 
       newState = {
         ...newState,
-        customer
+        customer,
+        message: 'hi'
       };
       newState = getComponentsFormFields(customer, newState);
       newState = setValueFormFields(customer, newState);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	feature request	0050403		closed	caristu	Support customer creation through the CRM in offline
caused by	design defect	0051695		closed	ablasco	The layout and its components should render properly with different heights

Notes
(0151442) hgbot (developer) 2023-06-21 14:30	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1146 [^]

(0151456) hgbot (developer) 2023-06-21 17:34	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: e2cdc19af9900145431396086406f33b811e8024 Author: adrian.blasco <adrian.blasco@openbravo.com> Date: 21-06-2023 17:33:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e2cdc19af9900145431396086406f33b811e8024 [^] Fixes ISSUE-52802 Customer Dialog Form fixed in height when notification appears --- M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.scss ---

(0151457) hgbot (developer) 2023-06-21 17:34	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1146 [^]

Issue History
Date Modified	Username	Field	Change
2023-06-20 17:48	caristu	New Issue
2023-06-20 17:48	caristu	Assigned To	=> Retail
2023-06-20 17:48	caristu	File Added: Selection_152.png
2023-06-20 17:48	caristu	OBNetwork customer	=> No
2023-06-20 17:48	caristu	Triggers an Emergency Pack	=> No
2023-06-20 17:49	caristu	Relationship added	related to 0051695
2023-06-20 17:53	caristu	Summary	Customer form layout is broken when displaying a message in view mode => Customer form layout is broken when displaying a message
2023-06-20 17:53	caristu	Description Updated	View Revisions
2023-06-20 17:53	caristu	Steps to Reproduce Updated	View Revisions
2023-06-20 17:53	caristu	Proposed Solution updated
2023-06-20 17:57	caristu	Relationship added	related to 0050403
2023-06-20 17:59	caristu	File Added: forceMessage.diff
2023-06-20 17:59	caristu	Relationship deleted	related to 0051695
2023-06-20 18:00	caristu	Relationship added	caused by 0051695
2023-06-21 11:30	AugustoMauch	Assigned To	Retail => ablasco
2023-06-21 14:30	hgbot	Merge Request Status	=> open
2023-06-21 14:30	hgbot	Note Added: 0151442
2023-06-21 17:34	hgbot	Merge Request Status	open => approved
2023-06-21 17:34	hgbot	Resolution	open => fixed
2023-06-21 17:34	hgbot	Status	new => closed
2023-06-21 17:34	hgbot	Fixed in Version	=> 23Q3
2023-06-21 17:34	hgbot	Note Added: 0151456
2023-06-21 17:34	hgbot	Note Added: 0151457

Copyright © 2000 - 2009 MantisBT Group