Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052802POS2POSpublic2023-06-20 17:482023-06-21 17:34
Reportercaristu 
Assigned Toablasco 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052802: Customer form layout is broken when displaying a message
DescriptionCustomer form layout is broken when displaying a message: the buttons in the bottom are cropped
Steps To Reproduce0) Apply the attached patch in org.openbravo.pos2 module which forces a message appear in the customer form

Option 1:
1) Click on the ticket business partner button and search for a business partner
2) Select one business partner to assign it to the ticket
3) Click again on the business partner button and select the "View Info" menu option. The customer form is opened with the info but the buttons in the bottom are cropped.


Option 2:
1) Click on the ticket business partner button and search for a business partner
2) Click on the create new button
3) The customer form is opened in edit view but the buttons in the bottom are cropped
Proposed SolutionRemoving grid-template-rows from this style[1] seems to fix the problem, but need to be tested because I'm not sure if it could break any other thing.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss#L72 [^]
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0050403 closed caristu Support customer creation through the CRM in offline 
caused by design defect 0051695 closed ablasco The layout and its components should render properly with different heights 
Attached Filespng Selection_152.png (23,806) 2023-06-20 17:48
https://issues.openbravo.com/file_download.php?file_id=18665&type=bug
png

diff forceMessage.diff (722) 2023-06-20 17:59
https://issues.openbravo.com/file_download.php?file_id=18667&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-06-20 17:48caristuNew Issue
2023-06-20 17:48caristuAssigned To => Retail
2023-06-20 17:48caristuFile Added: Selection_152.png
2023-06-20 17:48caristuOBNetwork customer => No
2023-06-20 17:48caristuTriggers an Emergency Pack => No
2023-06-20 17:49caristuRelationship addedrelated to 0051695
2023-06-20 17:53caristuSummaryCustomer form layout is broken when displaying a message in view mode => Customer form layout is broken when displaying a message
2023-06-20 17:53caristuDescription Updatedbug_revision_view_page.php?rev_id=26299#r26299
2023-06-20 17:53caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26301#r26301
2023-06-20 17:53caristuProposed Solution updated
2023-06-20 17:57caristuRelationship addedrelated to 0050403
2023-06-20 17:59caristuFile Added: forceMessage.diff
2023-06-20 17:59caristuRelationship deletedrelated to 0051695
2023-06-20 18:00caristuRelationship addedcaused by 0051695
2023-06-21 11:30AugustoMauchAssigned ToRetail => ablasco
2023-06-21 14:30hgbotMerge Request Status => open
2023-06-21 14:30hgbotNote Added: 0151442
2023-06-21 17:34hgbotMerge Request Statusopen => approved
2023-06-21 17:34hgbotResolutionopen => fixed
2023-06-21 17:34hgbotStatusnew => closed
2023-06-21 17:34hgbotFixed in Version => 23Q3
2023-06-21 17:34hgbotNote Added: 0151456
2023-06-21 17:34hgbotNote Added: 0151457

Notes
(0151442)
hgbot   
2023-06-21 14:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1146 [^]
(0151456)
hgbot   
2023-06-21 17:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e2cdc19af9900145431396086406f33b811e8024
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 21-06-2023 17:33:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e2cdc19af9900145431396086406f33b811e8024 [^]

Fixes ISSUE-52802 Customer Dialog Form fixed in height when notification appears

---
M web-jspack/org.openbravo.core2/src/components/Form/BaseForm.scss
---
(0151457)
hgbot   
2023-06-21 17:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1146 [^]