0052767: orgdsIds parameter wrongly spelled in REM_AddRemittance.java

Description

orgdsIds parameter wrongly spelled in REM_AddRemittance.java

Steps To Reproduce

Check the code of REM_AddRemittance class
The parameter in the whereClause is orgdsIds and when it is assigned it is orgids

      // @formatter:off
      String whereClause = ""
          + " as psd " // pending scheduled payments //
          + " left outer join psd.orderPaymentSchedule as ops"
          + " left outer join ops.order as ord "
          + " left outer join ord.businessPartner as obp "
          + " left outer join ops.fINPaymentPriority as opriority "
          + " left outer join psd.invoicePaymentSchedule ips "
          + " left outer join ips.invoice as inv "
          + " left outer join inv.businessPartner as ibp "
          + " left outer join ips.fINPaymentPriority as ipriority "
          + " where psd.paymentDetails is null"
          + " and psd.organization.id in :orgdsIds";

      parameters.put("orgids", OBContext.getOBContext()
          .getOrganizationStructureProvider()
          .getChildTree(organization.getId(), true));

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

defect

0051594

closed

francisco_ofarril

Several files in org.openbravo.module.remittance are not using bind-params and are not following HQL-style

Notes
(0151316) hgbot (developer) 2023-06-19 16:09	Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/9 [^]

(0151368) hgbot (developer) 2023-06-20 12:17	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^] Changeset: 83a462bdcc9a73579d9c7a679a32994ef3d417e2 Author: Frank González <frank.gonzalez@openbravo.com> Date: 20-06-2023 10:17:54 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/83a462bdcc9a73579d9c7a679a32994ef3d417e2 [^] Fixes ISSUE-52767: Corrected typo in where clause, 'orgdsIds' -> 'orgids' --- M src/org/openbravo/module/remittance/process/REM_AddRemittance.java ---

(0151369) hgbot (developer) 2023-06-20 12:17	Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/9 [^]

Issue History
Date Modified	Username	Field	Change
2023-06-16 12:07	ngarcia	New Issue
2023-06-16 12:07	ngarcia	Assigned To	=> Triage Omni OMS
2023-06-16 12:07	ngarcia	OBNetwork customer	=> No
2023-06-16 12:08	ngarcia	Support ticket	=> 66749
2023-06-16 12:08	ngarcia	OBNetwork customer	No => OBPS
2023-06-16 12:08	ngarcia	Relationship added	caused by 0051594
2023-06-16 12:11	Practics	Issue Monitored: Practics
2023-06-16 12:27	aferraz	Assigned To	Triage Omni OMS => frank_gonzalez
2023-06-19 16:01	frank_gonzalez	Status	new => scheduled
2023-06-19 16:09	hgbot	Merge Request Status	=> open
2023-06-19 16:09	hgbot	Note Added: 0151316
2023-06-20 12:17	hgbot	Merge Request Status	open => approved
2023-06-20 12:17	hgbot	Resolution	open => fixed
2023-06-20 12:17	hgbot	Status	scheduled => closed
2023-06-20 12:17	hgbot	Note Added: 0151368
2023-06-20 12:17	hgbot	Note Added: 0151369