Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052466

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Retail API

major

always

2023-05-16 18:42

2023-06-20 09:19

Reporter

kchoperena

View Status

public

Assigned To

sreehari

Priority

high

Resolution

fixed

Fixed in Version

RR23Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052466: ExternalOrderLoader fails updating or shipping if the BP has 2 shipping address with the same name and only one for invoicing

Description

The ExternalOrderLoader has some checks regarding the business partner address information. There is a logic that throws an error when a customer has a shipping address and not an invoicing address

The error happens before this check. We are trying to obtain wrongly the addresses

Situation
The customer has:
- 1 invoicing address
- 2 shipping address with the same business partner location name

As the getAddressIdFromAddressName is wrongly checking the size of location list to return the first one, the ExternalOrderLoader is throwing an exception:

throw new OBException("Invoice location is missing for bp " + bpId + " for order json " + orderJson + " while shipping location is defined");

Steps To Reproduce

1.- In Web POS, create a new customer with different invoices for shipping and invoicing
2.- Create exactly the same address for shipping an assign it to the ticket
3.- Complete the ticket
4.- Using any REST tool, update the created order using the ExternalOrderLoader. You can also create it or whatever. The key is to use the same customer

RESULT:
The next error message will be received in the response ->

Invoice location is missing for bp 04326D2A5A03701125298C8796043335 for order json

Proposed Solution

Check in ExternalOrderLoader/getAddressIdFromAddressName method, that the size of result list is bigger than 0 instead of 1

Tags

No tags attached.

patch52466.diff [^] (606 bytes) 2023-05-16 18:43 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java b/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
index 81790222f..b9a45a06a 100644
--- a/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
+++ b/src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
@@ -1550,7 +1550,7 @@ public class ExternalOrderLoader extends OrderLoader {
         .setParameter("bpName", locName);
 
     final List<String> values = qry.list();
-    if (values.size() > 1) {
+    if (values.size() > 0) {
       bpLocationId = values.get(0);
     }
     return bpLocationId;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0150969) hgbot (developer) 2023-06-09 07:16	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1237 [^]

(0151349) hgbot (developer) 2023-06-20 09:19	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1237 [^]

(0151350) hgbot (developer) 2023-06-20 09:19	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 40a730eb6974eda9c438a5605167059627383d9d Author: Sreehari Venkataraman <sreehari@qualiantech.com> Date: 20-06-2023 06:19:01 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/40a730eb6974eda9c438a5605167059627383d9d [^] Fixes ISSUE-52466: Added address validation in ExternalOrderLoader added isActive checks in query added method overloading for getAddressIdFromAddressName *Handled null Boolean exception using BooleanUtils --- M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2023-05-16 18:42	kchoperena	New Issue
2023-05-16 18:42	kchoperena	Assigned To	=> Triage Platform Conn
2023-05-16 18:42	kchoperena	OBNetwork customer	=> Gold
2023-05-16 18:42	kchoperena	Triggers an Emergency Pack	=> No
2023-05-16 18:43	kchoperena	File Added: patch52466.diff
2023-05-18 17:13	adrianromero	Assigned To	Triage Platform Conn => Retail
2023-05-19 08:57	sreehari	Assigned To	Retail => sreehari
2023-05-19 08:58	sreehari	Status	new => scheduled
2023-06-09 07:16	hgbot	Merge Request Status	=> open
2023-06-09 07:16	hgbot	Note Added: 0150969
2023-06-20 09:10	hgbot	Merge Request Status	open => approved
2023-06-20 09:19	hgbot	Resolution	open => fixed
2023-06-20 09:19	hgbot	Status	scheduled => closed
2023-06-20 09:19	hgbot	Note Added: 0151349
2023-06-20 09:19	hgbot	Fixed in Version	=> RR23Q3
2023-06-20 09:19	hgbot	Note Added: 0151350

Copyright © 2000 - 2009 MantisBT Group