Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0052466 | Retail Modules | Retail API | public | 2023-05-16 18:42 | 2023-06-20 09:19 |
|
| Reporter | kchoperena | |
| Assigned To | sreehari | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR23Q3 | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | Gold |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0052466: ExternalOrderLoader fails updating or shipping if the BP has 2 shipping address with the same name and only one for invoicing |
| Description | The ExternalOrderLoader has some checks regarding the business partner address information. There is a logic that throws an error when a customer has a shipping address and not an invoicing address
The error happens before this check. We are trying to obtain wrongly the addresses
Situation
The customer has:
- 1 invoicing address
- 2 shipping address with the same business partner location name
As the getAddressIdFromAddressName is wrongly checking the size of location list to return the first one, the ExternalOrderLoader is throwing an exception:
throw new OBException("Invoice location is missing for bp " + bpId + " for order json " + orderJson + " while shipping location is defined");
|
| Steps To Reproduce | 1.- In Web POS, create a new customer with different invoices for shipping and invoicing
2.- Create exactly the same address for shipping an assign it to the ticket
3.- Complete the ticket
4.- Using any REST tool, update the created order using the ExternalOrderLoader. You can also create it or whatever. The key is to use the same customer
RESULT:
The next error message will be received in the response ->
Invoice location is missing for bp 04326D2A5A03701125298C8796043335 for order json |
| Proposed Solution | Check in ExternalOrderLoader/getAddressIdFromAddressName method, that the size of result list is bigger than 0 instead of 1 |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  patch52466.diff (606) 2023-05-16 18:43
https://issues.openbravo.com/file_download.php?file_id=18538&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-05-16 18:42 | kchoperena | New Issue | |
| 2023-05-16 18:42 | kchoperena | Assigned To | => Triage Platform Conn |
| 2023-05-16 18:42 | kchoperena | OBNetwork customer | => Gold |
| 2023-05-16 18:42 | kchoperena | Triggers an Emergency Pack | => No |
| 2023-05-16 18:43 | kchoperena | File Added: patch52466.diff | |
| 2023-05-18 17:13 | adrianromero | Assigned To | Triage Platform Conn => Retail |
| 2023-05-19 08:57 | sreehari | Assigned To | Retail => sreehari |
| 2023-05-19 08:58 | sreehari | Status | new => scheduled |
| 2023-06-09 07:16 | hgbot | Merge Request Status | => open |
| 2023-06-09 07:16 | hgbot | Note Added: 0150969 | |
| 2023-06-20 09:10 | hgbot | Merge Request Status | open => approved |
| 2023-06-20 09:19 | hgbot | Resolution | open => fixed |
| 2023-06-20 09:19 | hgbot | Status | scheduled => closed |
| 2023-06-20 09:19 | hgbot | Note Added: 0151349 | |
| 2023-06-20 09:19 | hgbot | Fixed in Version | => RR23Q3 |
| 2023-06-20 09:19 | hgbot | Note Added: 0151350 | |