Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051477 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2023-01-27 08:47 | 2023-01-30 11:11 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051477: Errors when saving keymap editor changes if there are more than 300 records in a keymap | |||||||
| Description | When saving the changes on a keymap layout, there is some code that checks if it needs to create new instances of Keymap models by comparing the data stored in memory with the data returned by a IndexedDB query (i.e. https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/prepareKeymapVersionForSaving.js#L126 [^]). The problem is that those queries do not specify a limit, so a default limit is set to 300. In that case, the system will think that it needs to create some new records because it mistakenly thinks that they do not exist yet, when the real problem is that they were not returned by the query because of the size limit | |||||||
| Steps To Reproduce | - Create a keymap version that has more than 300 manual products among all its keymap categories - Open that keymap in the Keymap Editor window in POS2. - Select its version and go to the edit layout screen - Make any change (update the position of a product, change a color, etc) - Save. There will be an Error While Importing in the backend, complaining about some constraint not being met | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0145931) hgbot (developer) 2023-01-27 11:51 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1485 [^] |
|
(0145940) hgbot (developer) 2023-01-27 14:41 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 1f9f65b1f43f7d85f4d6b3f2a6aaf5449750e8a5 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 27-01-2023 11:51:15 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1f9f65b1f43f7d85f4d6b3f2a6aaf5449750e8a5 [^] Fixes ISSUE-51477: Increases the limit of supported keymap products of a keymap version Before this change there was a implicit limit on the number of supported keymap products, set to 300. This limit was not intented, we are defining now a higher limit, that we could modify later on when we do further load tests --- A web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/getMasterdataModelBy.js M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/prepareKeymapCategoryForSaving.js M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/prepareKeymapProductsForSaving.js M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/prepareKeymapVersionForSaving.js --- |
|
(0145941) hgbot (developer) 2023-01-27 14:41 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1485 [^] |
|
(0145977) guilleaer (viewer) 2023-01-29 19:09 |
Backport for 23Q1 is required |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-01-27 08:47 | AugustoMauch | New Issue | |
| 2023-01-27 08:47 | AugustoMauch | Assigned To | => AugustoMauch |
| 2023-01-27 08:47 | AugustoMauch | OBNetwork customer | => No |
| 2023-01-27 08:47 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2023-01-27 11:51 | hgbot | Merge Request Status | => open |
| 2023-01-27 11:51 | hgbot | Note Added: 0145931 | |
| 2023-01-27 14:41 | hgbot | Merge Request Status | open => approved |
| 2023-01-27 14:41 | hgbot | Resolution | open => fixed |
| 2023-01-27 14:41 | hgbot | Status | new => closed |
| 2023-01-27 14:41 | hgbot | Fixed in Version | => 23Q2 |
| 2023-01-27 14:41 | hgbot | Note Added: 0145940 | |
| 2023-01-27 14:41 | hgbot | Note Added: 0145941 | |
| 2023-01-29 19:09 | guilleaer | Note Added: 0145977 | |
| 2023-01-30 11:11 | guilleaer | Status | closed => new |
| 2023-01-30 11:11 | guilleaer | Resolution | fixed => open |
| 2023-01-30 11:11 | guilleaer | Fixed in Version | 23Q2 => |
| 2023-01-30 11:11 | guilleaer | Status | new => scheduled |
| 2023-01-30 11:11 | guilleaer | Status | scheduled => resolved |
| 2023-01-30 11:11 | guilleaer | Resolution | open => fixed |
| 2023-01-30 11:11 | guilleaer | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |