0051477: Errors when saving keymap editor changes if there are more than 300 records in a keymap

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0051477

POS2

POS

public

2023-01-27 08:47

2023-01-30 11:11

Reporter

AugustoMauch

Assigned To

AugustoMauch

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0051477: Errors when saving keymap editor changes if there are more than 300 records in a keymap

Description

When saving the changes on a keymap layout, there is some code that checks if it needs to create new instances of Keymap models by comparing the data stored in memory with the data returned by a IndexedDB query (i.e. https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/utils/prepareKeymapVersionForSaving.js#L126 [^]).

The problem is that those queries do not specify a limit, so a default limit is set to 300. In that case, the system will think that it needs to create some new records because it mistakenly thinks that they do not exist yet, when the real problem is that they were not returned by the query because of the size limit

Steps To Reproduce

- Create a keymap version that has more than 300 manual products among all its keymap categories
- Open that keymap in the Keymap Editor window in POS2.
- Select its version and go to the edit layout screen
- Make any change (update the position of a product, change a color, etc)
- Save. There will be an Error While Importing in the backend, complaining about some constraint not being met

Proposed Solution

Additional Information