Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050919
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2022-11-16 14:122023-07-27 12:31
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionPR23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050919: Remove obsolete reference for ImageInfo (url-based) it was replaced by ImageInfoBLOB

DescriptionIn 2009 this project added a new image reference (aka ImageInfoBLOB) to store content of image files directly in the database:
http://wiki.openbravo.com/wiki/Projects:Image_Reference_BLOB [^]

Issue 18530 (from 3.0MP9 in 2012) added a modulescript ConvertImages to convert all file-based images (from deployed web/images) folder to be stored as BLOB/bytea in the ad_image.bindarydata column.

That also switched the remaining columns away from the old ad_reference_id=32.
The 3.0 backoffice UI code does not have specific code implemented for those but just "StringUIDefinition".

Checking today:
- No usage to ad_reference_id=32 is found (backoffice,mods/pmods, download of published module)
- No reference to the ImageInfo.html (i.e. from manual html code) in backoffice,mods/pmods/download of published modules

With all that there seems to be no reason to keep that old reference around.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00185303.0MP9 closedmarvintm Openbravo ERP The image field on product window has an incorrect reference. 
related to defect 0053119 closedshuehner Modules Fix dbconsistency issue indirectly caused by backoffice change in 50919 
related to defect 0053120 closedshuehner Modules Fix dbconsistency issue indirectly caused by backoffice change in 50919 
related to defect 0053121 closedshuehner Modules Fix dbconsistency issue indirectly caused by backoffice change in 50919 
blocks defect 0050924 closedshuehner Openbravo ERP #RecordRangeTad (aka: Selector Registry Range) is unused and should be removed. 

-  Notes
(0143709)
hgbot (developer)
2022-11-16 15:09

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/765 [^]
(0146169)
hgbot (developer)
2023-02-02 13:47

 Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/41 [^]
(0152922)
hgbot (developer)
2023-07-27 12:31

 Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 3094ea23f42cf7dfa197af080ecebd11d8372b7a
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 27-07-2023 10:00:05
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/3094ea23f42cf7dfa197af080ecebd11d8372b7a [^]

Related to ISSUE-50919: Accept API-change (to remove obsolete ImageInfo)

Removed:
- row from table AD_REFERENCE- ID: 32
- row from table OBCLKER_UIDEFINITION - ID: 4C51FDC958034C00BF2067AB74E665F5
- row from table AD_MODEL_OBJECT - ID: 800780
- row from table AD_MODEL_OBJECT_MAPPING - ID: 801024
- Java classes:
  - org.openbravo.wad.controls.WADImage
  - org.openbravo.reference.ui.UIImage

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.client.kernel/src-db/database/sourcedata/OBCLKER_UIDEFINITION.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_REFERENCE.xml
---
(0152923)
hgbot (developer)
2023-07-27 12:31

 Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/41 [^]
(0152924)
hgbot (developer)
2023-07-27 12:31

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e6d6a499806afe92f32d01a0d2e512938f614634
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 27-07-2023 10:31:23
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e6d6a499806afe92f32d01a0d2e512938f614634 [^]

Fixed ISSUE-50919. Remove obsolete ImageInfo 2.50 selector / reference

That is old style 2.50 selector popup which is related to the old
non-blob image reference with ad_reference_id=32

New ImageInfoBLOB reference was added in 2009 and existing images
auto-converted with the modulescript ConvertImages (issue 18530
in 2012 / 3.0MP9).
    
Remove that selector as obsolete and related element as obsolete:
- Selector Servlet and files + related AD elements, src-wad implementation
- old ad_reference_id=32 (no usage found across Snapshot_Dev + all modules)
- Mark column ad_image.imageurl + m_product.imageurl as deprecated
Extra benefit it removes one of only 3 files left still using the old xsql
deprecated paging feature).

---
M modules/org.openbravo.client.kernel/src-db/database/sourcedata/OBCLKER_UIDEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
R src-wad/src/org/openbravo/wad/controls/WADImage.html
R src-wad/src/org/openbravo/wad/controls/WADImage.java
R src-wad/src/org/openbravo/wad/controls/WADImage.xml
R src-wad/src/org/openbravo/wad/controls/WADImageXML.html
R src-wad/src/org/openbravo/wad/controls/WADImageXML.xml
R src/org/openbravo/erpCommon/info/ImageInfo.html
R src/org/openbravo/erpCommon/info/ImageInfo.java
R src/org/openbravo/erpCommon/info/ImageInfo.xml
R src/org/openbravo/erpCommon/info/ImageInfo_data.xsql
R src/org/openbravo/reference/ui/UIImage.java
---
(0152925)
hgbot (developer)
2023-07-27 12:31

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/765 [^]

- Issue History
Date Modified Username Field Change
2022-11-16 14:12 shuehner New Issue
2022-11-16 14:12 shuehner Assigned To => shuehner
2022-11-16 14:12 shuehner OBNetwork customer => No
2022-11-16 14:12 shuehner Modules => Core
2022-11-16 14:12 shuehner Triggers an Emergency Pack => No
2022-11-16 15:09 hgbot Merge Request Status => open
2022-11-16 15:09 hgbot Note Added: 0143709
2022-11-16 17:07 shuehner Relationship added blocks 0050924
2022-11-23 08:42 alostale Relationship added related to 0018530
2023-02-02 13:47 hgbot Note Added: 0146169
2023-07-27 09:09 hgbot Merge Request Status open => approved
2023-07-27 12:31 hgbot Note Added: 0152922
2023-07-27 12:31 hgbot Note Added: 0152923
2023-07-27 12:31 hgbot Resolution open => fixed
2023-07-27 12:31 hgbot Status new => closed
2023-07-27 12:31 hgbot Fixed in Version => PR23Q4
2023-07-27 12:31 hgbot Note Added: 0152924
2023-07-27 12:31 hgbot Note Added: 0152925
2023-08-01 17:14 shuehner Relationship added related to 0053119
2023-08-01 17:28 shuehner Relationship added related to 0053120
2023-08-01 17:32 shuehner Relationship added related to 0053121

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker