Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050275
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Discounts and Promotionsminorhave not tried2022-09-19 09:362022-10-03 21:10
ReporterjlopezView Statuspublic 
Assigned Tojlopez 
PrioritynormalResolutionfixedFixed in VersionRR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050275: [PROMO] Start/End Date in the tab 'Discount and Promotions || Organization'

DescriptionCreate 2 new optional fields/columns in the Organization Tab in the Discounts and promotions window named ‘Starting Date’ and ‘Ending Date’.
These new parameters should be taken into account when executing the logic in the Discounts and promotions engine.

When defining the Organization filters:
* In Apply to Organization included in the list:
  - If the Starting Date and Ending Date are empty: The discount applies only to the organization selected in the list.
  - If Starting Date has a value: The discount applies only to the organization selected in the list but only in dates after the starting date.
  - If Ending Date has a value: The discount applies only to the organization selected in the list but only in dates before the ending date.
  - If both date fields have value: The discount applies only to the organization selected in the list but only in dates after the starting date and before the ending date.
* In Apply to all Organization excluding the ones in the list:
  - If the Starting Date and Ending Date are empty: The discount applies to all organizations except the ones selected in the list.
  - If Starting Date has a value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates after the starting date.
  - If Ending Date has a value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates before the ending date
  - If both date fields have value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates after the starting date and before the ending date.

https://openbravo.atlassian.net/browse/RM-895 [^]
Steps To Reproduce*
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on feature request 0050389 closedjlopez Retail Modules API Change: Add dates check constraint on table: M_OFFER_ORGANIZATION 
blocks feature request 0050306 closedjlopez POS2 [PROMO] Start/End Date in the tab 'Discount and Promotions || Store Set' 

-  Notes
(0141216)
hgbot (developer)
2022-09-19 10:04

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]
(0141217)
hgbot (developer)
2022-09-19 10:27

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]
(0141257)
hgbot (developer)
2022-09-20 12:06

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]
(0141258)
hgbot (developer)
2022-09-20 12:56

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]
(0141275)
hgbot (developer)
2022-09-20 20:05

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]
(0141426)
hgbot (developer)
2022-09-27 20:05

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]
(0141590)
hgbot (developer)
2022-10-03 19:17

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4db7fb7dfb8a41fdb999ab4ac36625777970bb69
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:14:05
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4db7fb7dfb8a41fdb999ab4ac36625777970bb69 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]

---
M src-db/database/model/tables/M_OFFER_ORGANIZATION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
---
(0141591)
hgbot (developer)
2022-10-03 19:17

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]
(0141595)
hgbot (developer)
2022-10-03 19:50

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]
(0141596)
hgbot (developer)
2022-10-03 19:50

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2cca9cdee452e74ab59a7d813ff7f63a03fd7d2b
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:47:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2cca9cdee452e74ab59a7d813ff7f63a03fd7d2b [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]

---
A src/org/openbravo/retail/posterminal/master/DiscountFilterOrganization.java
A src/org/openbravo/retail/posterminal/master/DiscountFilterOrganizationProperties.java
A web/org.openbravo.retail.posterminal/app/model/masterdata/discount/DiscountFilterOrganizationModel.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/Pack.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/ProductPack.js
---
(0141597)
hgbot (developer)
2022-10-03 19:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 17645cf2d3058e586e453814587effcda2209cbe
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:55:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/17645cf2d3058e586e453814587effcda2209cbe [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]

---
M src-test/org/openbravo/pos2/process/StorePerimeterReportTest.java
M src/org/openbravo/pos2/process/StorePerimeterReport.java
---
(0141598)
hgbot (developer)
2022-10-03 19:56

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]
(0141599)
hgbot (developer)
2022-10-03 20:01

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]
(0141600)
hgbot (developer)
2022-10-03 20:01

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 5e78538f75e9a3bc0495f67eafea3c60f83518e1
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:59:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5e78538f75e9a3bc0495f67eafea3c60f83518e1 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]

---
A web-test/model/business-logic/discounts-engine/engine/discount-is-applicable.test.js
M src/org/openbravo/retail/discounts/master/DiscountFilterProperties.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0141601)
hgbot (developer)
2022-10-03 20:03

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 9e2109714bf7d25eddb14d79e3046176b10e6f10
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 20:03:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/9e2109714bf7d25eddb14d79e3046176b10e6f10 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0141602)
hgbot (developer)
2022-10-03 20:03

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]
(0141606)
hgbot (developer)
2022-10-03 21:10

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]
(0141607)
hgbot (developer)
2022-10-03 21:10

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 09c95114bf08f09dbcc112f3282bffac084892d8
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 21:10:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/09c95114bf08f09dbcc112f3282bffac084892d8 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]

---
M web/org.openbravo.retail.discounts.combo/app/model/business-logic/pack/Combo.js
---

- Issue History
Date Modified Username Field Change
2022-09-19 09:36 jlopez New Issue
2022-09-19 09:36 jlopez Assigned To => pjuvara
2022-09-19 09:37 jlopez Assigned To pjuvara => jlopez
2022-09-19 09:38 jlopez Description Updated View Revisions
2022-09-19 09:46 jlopez Type defect => feature request
2022-09-19 10:04 hgbot Note Added: 0141216
2022-09-19 10:27 hgbot Note Added: 0141217
2022-09-20 12:06 hgbot Note Added: 0141257
2022-09-20 12:56 hgbot Note Added: 0141258
2022-09-20 20:05 hgbot Note Added: 0141275
2022-09-27 20:05 hgbot Note Added: 0141426
2022-10-03 14:14 jlopez Relationship added related to 0050389
2022-10-03 14:26 aferraz Relationship replaced depends on 0050389
2022-10-03 14:27 aferraz Project Contribution Requests => Retail Modules
2022-10-03 14:27 aferraz Triggers an Emergency Pack => No
2022-10-03 14:27 aferraz Category Core Contributions => Discounts and Promotions
2022-10-03 14:36 jlopez Relationship added blocks 0050306
2022-10-03 19:17 hgbot Resolution open => fixed
2022-10-03 19:17 hgbot Status new => closed
2022-10-03 19:17 hgbot Fixed in Version => PR23Q1
2022-10-03 19:17 hgbot Note Added: 0141590
2022-10-03 19:17 hgbot Note Added: 0141591
2022-10-03 19:50 hgbot Note Added: 0141595
2022-10-03 19:50 hgbot Fixed in Version PR23Q1 => RR23Q1
2022-10-03 19:50 hgbot Note Added: 0141596
2022-10-03 19:56 hgbot Fixed in Version RR23Q1 => 23Q1
2022-10-03 19:56 hgbot Note Added: 0141597
2022-10-03 19:56 hgbot Note Added: 0141598
2022-10-03 20:01 hgbot Fixed in Version 23Q1 => RR23Q1
2022-10-03 20:01 hgbot Note Added: 0141599
2022-10-03 20:01 hgbot Note Added: 0141600
2022-10-03 20:03 hgbot Note Added: 0141601
2022-10-03 20:03 hgbot Note Added: 0141602
2022-10-03 21:10 hgbot Note Added: 0141606
2022-10-03 21:10 hgbot Note Added: 0141607

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker