Openbravo Issue Tracking System - Retail Modules
View Issue Details
0050275Retail ModulesDiscounts and Promotionspublic2022-09-19 09:362022-10-03 21:10
jlopez 
jlopez 
normalminorhave not tried
closedfixed 
5
 
RR23Q1 
No
0050275: [PROMO] Start/End Date in the tab 'Discount and Promotions || Organization'
Create 2 new optional fields/columns in the Organization Tab in the Discounts and promotions window named ‘Starting Date’ and ‘Ending Date’.
These new parameters should be taken into account when executing the logic in the Discounts and promotions engine.

When defining the Organization filters:
* In Apply to Organization included in the list:
  - If the Starting Date and Ending Date are empty: The discount applies only to the organization selected in the list.
  - If Starting Date has a value: The discount applies only to the organization selected in the list but only in dates after the starting date.
  - If Ending Date has a value: The discount applies only to the organization selected in the list but only in dates before the ending date.
  - If both date fields have value: The discount applies only to the organization selected in the list but only in dates after the starting date and before the ending date.
* In Apply to all Organization excluding the ones in the list:
  - If the Starting Date and Ending Date are empty: The discount applies to all organizations except the ones selected in the list.
  - If Starting Date has a value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates after the starting date.
  - If Ending Date has a value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates before the ending date
  - If both date fields have value: The discount applies only to the organizations and the ones included in the list are excluded but only for dates after the starting date and before the ending date.

https://openbravo.atlassian.net/browse/RM-895 [^]
*
No tags attached.
depends on feature request 0050389 closed jlopez Retail Modules API Change: Add dates check constraint on table: M_OFFER_ORGANIZATION 
blocks feature request 0050306 closed jlopez POS2 [PROMO] Start/End Date in the tab 'Discount and Promotions || Store Set' 
Issue History
2022-09-19 09:36jlopezNew Issue
2022-09-19 09:36jlopezAssigned To => pjuvara
2022-09-19 09:37jlopezAssigned Topjuvara => jlopez
2022-09-19 09:38jlopezDescription Updatedbug_revision_view_page.php?rev_id=24774#r24774
2022-09-19 09:46jlopezTypedefect => feature request
2022-09-19 10:04hgbotNote Added: 0141216
2022-09-19 10:27hgbotNote Added: 0141217
2022-09-20 12:06hgbotNote Added: 0141257
2022-09-20 12:56hgbotNote Added: 0141258
2022-09-20 20:05hgbotNote Added: 0141275
2022-09-27 20:05hgbotNote Added: 0141426
2022-10-03 14:14jlopezRelationship addedrelated to 0050389
2022-10-03 14:26aferrazRelationship replaceddepends on 0050389
2022-10-03 14:27aferrazProjectContribution Requests => Retail Modules
2022-10-03 14:27aferrazTriggers an Emergency Pack => No
2022-10-03 14:27aferrazCategoryCore Contributions => Discounts and Promotions
2022-10-03 14:36jlopezRelationship addedblocks 0050306
2022-10-03 19:17hgbotResolutionopen => fixed
2022-10-03 19:17hgbotStatusnew => closed
2022-10-03 19:17hgbotFixed in Version => PR23Q1
2022-10-03 19:17hgbotNote Added: 0141590
2022-10-03 19:17hgbotNote Added: 0141591
2022-10-03 19:50hgbotNote Added: 0141595
2022-10-03 19:50hgbotFixed in VersionPR23Q1 => RR23Q1
2022-10-03 19:50hgbotNote Added: 0141596
2022-10-03 19:56hgbotFixed in VersionRR23Q1 => 23Q1
2022-10-03 19:56hgbotNote Added: 0141597
2022-10-03 19:56hgbotNote Added: 0141598
2022-10-03 20:01hgbotFixed in Version23Q1 => RR23Q1
2022-10-03 20:01hgbotNote Added: 0141599
2022-10-03 20:01hgbotNote Added: 0141600
2022-10-03 20:03hgbotNote Added: 0141601
2022-10-03 20:03hgbotNote Added: 0141602
2022-10-03 21:10hgbotNote Added: 0141606
2022-10-03 21:10hgbotNote Added: 0141607

Notes
(0141216)
hgbot   
2022-09-19 10:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]
(0141217)
hgbot   
2022-09-19 10:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]
(0141257)
hgbot   
2022-09-20 12:06   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]
(0141258)
hgbot   
2022-09-20 12:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]
(0141275)
hgbot   
2022-09-20 20:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]
(0141426)
hgbot   
2022-09-27 20:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]
(0141590)
hgbot   
2022-10-03 19:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 4db7fb7dfb8a41fdb999ab4ac36625777970bb69
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:14:05
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4db7fb7dfb8a41fdb999ab4ac36625777970bb69 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]

---
M src-db/database/model/tables/M_OFFER_ORGANIZATION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/businessUtility/PriceAdjustment.java
---
(0141591)
hgbot   
2022-10-03 19:17   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/714 [^]
(0141596)
hgbot   
2022-10-03 19:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2cca9cdee452e74ab59a7d813ff7f63a03fd7d2b
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:47:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2cca9cdee452e74ab59a7d813ff7f63a03fd7d2b [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]

---
A src/org/openbravo/retail/posterminal/master/DiscountFilterOrganization.java
A src/org/openbravo/retail/posterminal/master/DiscountFilterOrganizationProperties.java
A web/org.openbravo.retail.posterminal/app/model/masterdata/discount/DiscountFilterOrganizationModel.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/Pack.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/ProductPack.js
---
(0141595)
hgbot   
2022-10-03 19:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/926 [^]
(0141597)
hgbot   
2022-10-03 19:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 17645cf2d3058e586e453814587effcda2209cbe
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:55:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/17645cf2d3058e586e453814587effcda2209cbe [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]

---
M src-test/org/openbravo/pos2/process/StorePerimeterReportTest.java
M src/org/openbravo/pos2/process/StorePerimeterReport.java
---
(0141598)
hgbot   
2022-10-03 19:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1216 [^]
(0141599)
hgbot   
2022-10-03 20:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]
(0141600)
hgbot   
2022-10-03 20:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 5e78538f75e9a3bc0495f67eafea3c60f83518e1
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 19:59:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5e78538f75e9a3bc0495f67eafea3c60f83518e1 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/65 [^]

---
A web-test/model/business-logic/discounts-engine/engine/discount-is-applicable.test.js
M src/org/openbravo/retail/discounts/master/DiscountFilterProperties.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-engine.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---
(0141601)
hgbot   
2022-10-03 20:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 9e2109714bf7d25eddb14d79e3046176b10e6f10
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 20:03:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/9e2109714bf7d25eddb14d79e3046176b10e6f10 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0141602)
hgbot   
2022-10-03 20:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/18 [^]
(0141606)
hgbot   
2022-10-03 21:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]
(0141607)
hgbot   
2022-10-03 21:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 09c95114bf08f09dbcc112f3282bffac084892d8
Author: Javier López <javier.lopez@precognis.com>
Date: 03-10-2022 21:10:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/09c95114bf08f09dbcc112f3282bffac084892d8 [^]

Fixes FR-50275: Start/End Date in the tab 'Discount and Promotions || Organization'

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/24 [^]

---
M web/org.openbravo.retail.discounts.combo/app/model/business-logic/pack/Combo.js
---