Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049852
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Corecriticalalways2022-07-18 16:182022-08-03 12:29
Reportertimothee_catteeuwView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version22Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049852: JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures

DescriptionIn production, there is a case which blocks API sales closure process when closing the till.

It happened when you do a verified return without selecting an amount in payment screen and directly click on finish button.

Be careful because you can have the same behavior for a blind return so to take into account as well

Steps To ReproduceOn Web POS

go to Webpos and login

open sales history

on a paid (and not retuned) order, click verified return option

select 1 or several products and apply button

click refund button

directly click Done button and print button

When “Payment Amount is Wrong” popin appears click “OK”

close your till

On BO :

open the EDL resquest window

you can see an error on API Sales closure process like :

org.openbravo.base.exception.OBException: Error processing order 01940052/0000005 with Exception java.lang.NullPointerExceptionat com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureUtils.setPayments(SalesClosureUtils.java:312)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.buildUniSalesObject(SalesClosureItemProcessor.java:315)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:70)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:50)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.doProcessBatchWithInput(AsynchronousProcessor.java:261)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatchWithInput(AsynchronousProcessor.java:232)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatch(AsynchronousProcessor.java:215)at org.openbravo.externaldata.integration.process.ProcessRequest.processRequestLine(ProcessRequest.java:594)at org.openbravo.externaldata.integration.process.EDLImportEntryProcessor$EDLEntryProcessRunnable.processEntry(EDLImportEntryProcessor.java:157)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338)at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)at java.base/java.lang.Thread.run(Thread.java:829)
Proposed Solution1) oblige the user to select an amount when verified return.
I think it does not make sense to return products from a customer without giving the amount initially paid
2) manage this specific case in the API sales closure (ticket not not fully paid process)
3) deactivate Payment not fully paid process
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0049832 closedjavierRodriguez JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures 

-  Notes
(0139547)
hgbot (developer)
2022-07-22 12:36

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1102 [^]
(0139837)
hgbot (developer)
2022-08-03 12:29

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1102 [^]
(0139838)
hgbot (developer)
2022-08-03 12:29

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b487b81ab97001522e1da64ce1785ef0de1cd403
Author: Javier Rodríguez Regueiro <javier.rodriguez@openbravo.com>
Date: 03-08-2022 10:29:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b487b81ab97001522e1da64ce1785ef0de1cd403 [^]

Fixed ISSUE-49852: Ensure to have all payments in verified return before complete the ticket

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/CompleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/CompleteTicket.js
---

- Issue History
Date Modified Username Field Change
2022-07-20 11:06 guilleaer Type defect => backport
2022-07-20 11:06 guilleaer Target Version => 22Q3
2022-07-22 11:53 guilleaer Assigned To Triage Platform Base => javierRodriguez
2022-07-22 12:36 hgbot Merge Request Status => open
2022-07-22 12:36 hgbot Note Added: 0139547
2022-08-03 11:43 hgbot Merge Request Status open => approved
2022-08-03 12:29 hgbot Resolution open => fixed
2022-08-03 12:29 hgbot Status scheduled => closed
2022-08-03 12:29 hgbot Note Added: 0139837
2022-08-03 12:29 hgbot Fixed in Version => 22Q3
2022-08-03 12:29 hgbot Note Added: 0139838

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker