0049852: JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0049852

POS2

Core

public

2022-07-18 16:18

2022-08-03 12:29

Reporter

timothee_catteeuw

Assigned To

javierRodriguez

Priority

normal

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

22Q3

Fixed in Version

22Q3

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0049852: JIRA 3173 -Payment not fully paid are authorized ( ex : no amount selected when return (this behavior causes problem on closures

Description

In production, there is a case which blocks API sales closure process when closing the till.

It happened when you do a verified return without selecting an amount in payment screen and directly click on finish button.

Be careful because you can have the same behavior for a blind return so to take into account as well

Steps To Reproduce

On Web POS

go to Webpos and login

open sales history

on a paid (and not retuned) order, click verified return option

select 1 or several products and apply button

click refund button

directly click Done button and print button

When “Payment Amount is Wrong” popin appears click “OK”

close your till

On BO :

open the EDL resquest window

you can see an error on API Sales closure process like :

org.openbravo.base.exception.OBException: Error processing order 01940052/0000005 with Exception java.lang.NullPointerExceptionat com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureUtils.setPayments(SalesClosureUtils.java:312)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.buildUniSalesObject(SalesClosureItemProcessor.java:315)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:70)at com.openbravo.XXXX.integration.comarch.cashup.processor.SalesClosureItemProcessor.processItem(SalesClosureItemProcessor.java:50)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.doProcessBatchWithInput(AsynchronousProcessor.java:261)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatchWithInput(AsynchronousProcessor.java:232)at org.openbravo.externaldata.integration.process.AsynchronousProcessor.processBatch(AsynchronousProcessor.java:215)at org.openbravo.externaldata.integration.process.ProcessRequest.processRequestLine(ProcessRequest.java:594)at org.openbravo.externaldata.integration.process.EDLImportEntryProcessor$EDLEntryProcessRunnable.processEntry(EDLImportEntryProcessor.java:157)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421)at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338)at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)at java.base/java.lang.Thread.run(Thread.java:829)

Proposed Solution

1) oblige the user to select an amount when verified return.
I think it does not make sense to return products from a customer without giving the amount initially paid
2) manage this specific case in the API sales closure (ticket not not fully paid process)
3) deactivate Payment not fully paid process

Additional Information