Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0049385
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Restaurantsminoralways2022-05-24 14:352022-06-16 10:18
ReporterFelixakaView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0049385: JIRA - 3022 Regression : "Missinfg configuration" On the virtual ticket is shown

DescriptionWhen we chose all configutation for a product, there is the message “Missing configuratuon” that it is shown

Issue is reproducible in https://agapes-fs-u18-test.cloud.openbravo.com/openbravo/web/pos/ [^] when adding to the ticket the Entrecote VBF product, in the Restaurant -> Grillade category

There seems to be two issues here, probably related:
1- When a first modifier is set, the modifier is added to the product. If the second modifier has a default value and "Next" is clicked without selecting other option, the second modifier is not set (apparently the state action is invoked but with the info of the first modifier). See attached videos SecondModifierDefault and SecondModifierNonDefault
2- Even if the second modifier is properly set, still a #Missing configuration message is displayed (see MissingConfiguration video)
Steps To Reproduce-Go on the POS

- Chose an article with some modifier in the POS (Ex : Entrecote vbf)

- select the modifier of the article

- Go on paid

- See that there is the messsage "Missing configuration" in the virtual ticket (See picture)

TagsNo tags attached.
Attached Filesgif file icon ProductWithModifiers.gif [^] (918,638 bytes) 2022-05-26 18:10
png file icon 2022-05-27_09h09_22.png [^] (47,144 bytes) 2022-05-27 09:10


gif file icon SecondModifierDefault.gif [^] (330,685 bytes) 2022-05-28 11:13
gif file icon SecondModifierNonDefault.gif [^] (359,463 bytes) 2022-05-28 11:13
gif file icon MissingConfiguration.gif [^] (449,720 bytes) 2022-05-28 11:13
png file icon 2022-06-10_17h33_11.png [^] (110,723 bytes) 2022-06-10 17:38

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0049585 newRetail Delivery configuration should be added to the product.configuration instead of on the ticketline 

-  Notes
(0137786)
AugustoMauch (administrator)
2022-05-26 18:09

 Felix, I just tested this issue in livebuilds and it works properly, check attached gif.

Did you miss any steps to reproduce?
(0137806)
Felixaka (developer)
2022-05-27 09:12

 Hello Augusto,

Here we need to chose a product with a modifier (exemple : Entrecote) finish his configuration and see that there is the message (Missing configuration) as in the picture
(0138035)
hgbot (developer)
2022-06-04 10:41

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/985 [^]
(0138210)
hgbot (developer)
2022-06-09 12:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 26e387eeb24add634162d6b5f9fcd2bbc1466ff7
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 09-06-2022 10:59:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/26e387eeb24add634162d6b5f9fcd2bbc1466ff7 [^]

Fixes ISSUE-49385: Unneeded extra configuration message shown when using pager configuration

The problem is that the pager configuration is not modeled using Product Modifiers but it is reusing part of the
infrastructure. As a result, a "# Missing configuration" message is displayed. Because reimplementing the pager
configuration is out of the scope of this issue, we solve it by not rendering the missing configuration message
if the product does not include configuration information

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/ProductConfiguration.jsx
---
(0138211)
hgbot (developer)
2022-06-09 12:59

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/985 [^]
(0138289)
Felixaka (developer)
2022-06-10 17:38

 Hello,

The probleme is still present for in FS test

For exemple if i choose a product with a timer / pager we still have the message "Missing configuration"

See picture
(0138374)
hgbot (developer)
2022-06-15 13:55

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1009 [^]
(0138395)
hgbot (developer)
2022-06-16 10:18

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 89cb1ba70fc997013daa63e5433317f854ca5028
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-06-2022 08:18:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89cb1ba70fc997013daa63e5433317f854ca5028 [^]

Fixes ISSUE-49385: Unneeded extra configuration message shown when using pager configuration

The problem was that there were some flows (i.e. pager) that use the ProductConfiguration component but that
do not include the configuration values on the product.configuration object. As a consequence, the component
was not being rerendered when those values were set, and the "# Missing Configuration" message was still displayed
in the line even after setting al mandatory values.

To fix it, the component now keeps track of a list of extra properties outside de configuration object that it must
listen to, so that when any of those change the component will be rendered again and the missing configuration object
will be removed

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/ProductConfiguration.jsx
---
(0138396)
hgbot (developer)
2022-06-16 10:18

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1009 [^]

- Issue History
Date Modified Username Field Change
2022-05-24 14:35 Felixaka New Issue
2022-05-24 14:35 Felixaka Assigned To => Retail
2022-05-24 14:35 Felixaka Triggers an Emergency Pack => No
2022-05-26 18:09 AugustoMauch Note Added: 0137786
2022-05-26 18:09 AugustoMauch Status new => feedback
2022-05-26 18:10 AugustoMauch Assigned To Retail => Felixaka
2022-05-26 18:10 AugustoMauch File Added: ProductWithModifiers.gif
2022-05-27 09:08 Felixaka Summary JIRA - 3022 Regression : "Missinf configuration" On the virtual ticket is shown => JIRA - 3022 Regression : "Missinfg configuration" On the virtual ticket is shown
2022-05-27 09:10 Felixaka File Added: 2022-05-27_09h09_22.png
2022-05-27 09:10 Felixaka Steps to Reproduce Updated View Revisions
2022-05-27 09:12 Felixaka Note Added: 0137806
2022-05-27 09:12 Felixaka Assigned To Felixaka => AugustoMauch
2022-05-28 10:32 AugustoMauch Steps to Reproduce Updated View Revisions
2022-05-28 10:32 AugustoMauch Status feedback => scheduled
2022-05-28 11:11 AugustoMauch Description Updated View Revisions
2022-05-28 11:11 AugustoMauch Steps to Reproduce Updated View Revisions
2022-05-28 11:13 AugustoMauch File Added: SecondModifierDefault.gif
2022-05-28 11:13 AugustoMauch File Added: SecondModifierNonDefault.gif
2022-05-28 11:13 AugustoMauch File Added: MissingConfiguration.gif
2022-05-30 09:12 Felixaka Steps to Reproduce Updated View Revisions
2022-06-02 16:56 AugustoMauch Assigned To AugustoMauch => ablasco
2022-06-04 10:41 hgbot Note Added: 0138035
2022-06-09 12:59 hgbot Resolution open => fixed
2022-06-09 12:59 hgbot Status scheduled => closed
2022-06-09 12:59 hgbot Note Added: 0138210
2022-06-09 12:59 hgbot Note Added: 0138211
2022-06-10 17:38 Felixaka Note Added: 0138289
2022-06-10 17:38 Felixaka File Added: 2022-06-10_17h33_11.png
2022-06-10 17:39 Felixaka Note Added: 0138290
2022-06-10 17:39 Felixaka Status closed => new
2022-06-10 17:39 Felixaka Resolution fixed => open
2022-06-13 13:15 guilleaer Note Deleted: 0138290
2022-06-15 13:55 hgbot Note Added: 0138374
2022-06-15 13:59 AugustoMauch Assigned To ablasco => AugustoMauch
2022-06-15 19:43 AugustoMauch Status new => scheduled
2022-06-16 10:18 hgbot Resolution open => fixed
2022-06-16 10:18 hgbot Status scheduled => closed
2022-06-16 10:18 hgbot Note Added: 0138395
2022-06-16 10:18 hgbot Note Added: 0138396
2022-06-16 14:04 cberner Relationship added related to 0049585

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker