Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0049385 | POS2 | Restaurants | public | 2022-05-24 14:35 | 2022-06-16 10:18 |
|
| Reporter | Felixaka | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0049385: JIRA - 3022 Regression : "Missinfg configuration" On the virtual ticket is shown |
| Description | When we chose all configutation for a product, there is the message “Missing configuratuon” that it is shown
Issue is reproducible in https://agapes-fs-u18-test.cloud.openbravo.com/openbravo/web/pos/ [^] when adding to the ticket the Entrecote VBF product, in the Restaurant -> Grillade category
There seems to be two issues here, probably related:
1- When a first modifier is set, the modifier is added to the product. If the second modifier has a default value and "Next" is clicked without selecting other option, the second modifier is not set (apparently the state action is invoked but with the info of the first modifier). See attached videos SecondModifierDefault and SecondModifierNonDefault
2- Even if the second modifier is properly set, still a #Missing configuration message is displayed (see MissingConfiguration video) |
| Steps To Reproduce | -Go on the POS
- Chose an article with some modifier in the POS (Ex : Entrecote vbf)
- select the modifier of the article
- Go on paid
- See that there is the messsage "Missing configuration" in the virtual ticket (See picture)
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0049585 | | new | Retail | Delivery configuration should be added to the product.configuration instead of on the ticketline |
|
| Attached Files |  ProductWithModifiers.gif (918,638) 2022-05-26 18:10
https://issues.openbravo.com/file_download.php?file_id=17068&type=bug
 2022-05-27_09h09_22.png (47,144) 2022-05-27 09:10
https://issues.openbravo.com/file_download.php?file_id=17069&type=bug
SecondModifierDefault.gif (330,685) 2022-05-28 11:13
https://issues.openbravo.com/file_download.php?file_id=17077&type=bug
SecondModifierNonDefault.gif (359,463) 2022-05-28 11:13
https://issues.openbravo.com/file_download.php?file_id=17078&type=bug
MissingConfiguration.gif (449,720) 2022-05-28 11:13
https://issues.openbravo.com/file_download.php?file_id=17079&type=bug
2022-06-10_17h33_11.png (110,723) 2022-06-10 17:38
https://issues.openbravo.com/file_download.php?file_id=17148&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2022-05-24 14:35 | Felixaka | New Issue | |
| 2022-05-24 14:35 | Felixaka | Assigned To | => Retail |
| 2022-05-24 14:35 | Felixaka | Triggers an Emergency Pack | => No |
| 2022-05-26 18:09 | AugustoMauch | Note Added: 0137786 | |
| 2022-05-26 18:09 | AugustoMauch | Status | new => feedback |
| 2022-05-26 18:10 | AugustoMauch | Assigned To | Retail => Felixaka |
| 2022-05-26 18:10 | AugustoMauch | File Added: ProductWithModifiers.gif | |
| 2022-05-27 09:08 | Felixaka | Summary | JIRA - 3022 Regression : "Missinf configuration" On the virtual ticket is shown => JIRA - 3022 Regression : "Missinfg configuration" On the virtual ticket is shown |
| 2022-05-27 09:10 | Felixaka | File Added: 2022-05-27_09h09_22.png | |
| 2022-05-27 09:10 | Felixaka | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=24169#r24169 |
| 2022-05-27 09:12 | Felixaka | Note Added: 0137806 | |
| 2022-05-27 09:12 | Felixaka | Assigned To | Felixaka => AugustoMauch |
| 2022-05-28 10:32 | AugustoMauch | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=24184#r24184 |
| 2022-05-28 10:32 | AugustoMauch | Status | feedback => scheduled |
| 2022-05-28 11:11 | AugustoMauch | Description Updated | bug_revision_view_page.php?rev_id=24186#r24186 |
| 2022-05-28 11:11 | AugustoMauch | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=24187#r24187 |
| 2022-05-28 11:13 | AugustoMauch | File Added: SecondModifierDefault.gif | |
| 2022-05-28 11:13 | AugustoMauch | File Added: SecondModifierNonDefault.gif | |
| 2022-05-28 11:13 | AugustoMauch | File Added: MissingConfiguration.gif | |
| 2022-05-30 09:12 | Felixaka | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=24188#r24188 |
| 2022-06-02 16:56 | AugustoMauch | Assigned To | AugustoMauch => ablasco |
| 2022-06-04 10:41 | hgbot | Note Added: 0138035 | |
| 2022-06-09 12:59 | hgbot | Resolution | open => fixed |
| 2022-06-09 12:59 | hgbot | Status | scheduled => closed |
| 2022-06-09 12:59 | hgbot | Note Added: 0138210 | |
| 2022-06-09 12:59 | hgbot | Note Added: 0138211 | |
| 2022-06-10 17:38 | Felixaka | Note Added: 0138289 | |
| 2022-06-10 17:38 | Felixaka | File Added: 2022-06-10_17h33_11.png | |
| 2022-06-10 17:39 | Felixaka | Note Added: 0138290 | |
| 2022-06-10 17:39 | Felixaka | Status | closed => new |
| 2022-06-10 17:39 | Felixaka | Resolution | fixed => open |
| 2022-06-13 13:15 | guilleaer | Note Deleted: 0138290 | |
| 2022-06-15 13:55 | hgbot | Note Added: 0138374 | |
| 2022-06-15 13:59 | AugustoMauch | Assigned To | ablasco => AugustoMauch |
| 2022-06-15 19:43 | AugustoMauch | Status | new => scheduled |
| 2022-06-16 10:18 | hgbot | Resolution | open => fixed |
| 2022-06-16 10:18 | hgbot | Status | scheduled => closed |
| 2022-06-16 10:18 | hgbot | Note Added: 0138395 | |
| 2022-06-16 10:18 | hgbot | Note Added: 0138396 | |
| 2022-06-16 14:04 | cberner | Relationship added | related to 0049585 |
|
Notes |
|
|
|
Felix, I just tested this issue in livebuilds and it works properly, check attached gif.
Did you miss any steps to reproduce? |
|
|
|
|
Hello Augusto,
Here we need to chose a product with a modifier (exemple : Entrecote) finish his configuration and see that there is the message (Missing configuration) as in the picture |
|
|
|
(0138035)
|
|
hgbot
|
|
2022-06-04 10:41
|
|
|
|
|
(0138210)
|
|
hgbot
|
|
2022-06-09 12:59
|
|
|
|
|
(0138211)
|
|
hgbot
|
|
2022-06-09 12:59
|
|
|
|
|
|
Hello,
The probleme is still present for in FS test
For exemple if i choose a product with a timer / pager we still have the message "Missing configuration"
See picture |
|
|
|
(0138374)
|
|
hgbot
|
|
2022-06-15 13:55
|
|
|
|
|
(0138395)
|
|
hgbot
|
|
2022-06-16 10:18
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 89cb1ba70fc997013daa63e5433317f854ca5028
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-06-2022 08:18:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/89cb1ba70fc997013daa63e5433317f854ca5028 [^]
Fixes ISSUE-49385: Unneeded extra configuration message shown when using pager configuration
The problem was that there were some flows (i.e. pager) that use the ProductConfiguration component but that
do not include the configuration values on the product.configuration object. As a consequence, the component
was not being rerendered when those values were set, and the "# Missing Configuration" message was still displayed
in the line even after setting al mandatory values.
To fix it, the component now keeps track of a list of extra properties outside de configuration object that it must
listen to, so that when any of those change the component will be rendered again and the missing configuration object
will be removed
---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/ProductConfiguration.jsx
---
|
|
|
|
(0138396)
|
|
hgbot
|
|
2022-06-16 10:18
|
|
|