Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0049311 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-05-12 15:59 | 2022-06-03 09:45 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | Triage Platform Base | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | PR22Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0049311: jest coverage report is inaccurate | |||||||
Description | Jest coverage report is inaccurate because: 1. It is reporting coverage on some libraries (ie. redux) 2. It only reports coverage on files that are under test or imported by them, not taking into account files that are completely untested | |||||||
Steps To Reproduce | 1. In a retail instance run: npm run coverage 2. Check: - There is coverage report for redux libraries - There is no coverage report for untested files (ie. SetContextAndPopup.js) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0137225) hgbot (developer) 2022-05-12 16:04 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/595 [^] |
(0138021) hgbot (developer) 2022-06-03 09:45 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: feef8e6c5a51312ca1d2432ea419c0dcbef97454 Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 03-06-2022 09:44:56 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/feef8e6c5a51312ca1d2432ea419c0dcbef97454 [^] fixes BUG-49311: jest coverage report is inaccurate Explicitly defines which are the files that should be taken into consideration for the coverage report: * includes web-jspack and web/*/app, react pos and post indexeddb enyo pos files. This makes untested files to be included also. * excludes libraries and other non relevant paths --- M package.json --- |
(0138022) hgbot (developer) 2022-06-03 09:45 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/595 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2022-05-12 15:59 | alostale | New Issue | |
2022-05-12 15:59 | alostale | Assigned To | => Triage Platform Base |
2022-05-12 15:59 | alostale | OBNetwork customer | => No |
2022-05-12 15:59 | alostale | Modules | => Core |
2022-05-12 15:59 | alostale | Triggers an Emergency Pack | => No |
2022-05-12 16:04 | hgbot | Merge Request Status | => open |
2022-05-12 16:04 | hgbot | Note Added: 0137225 | |
2022-06-03 09:44 | hgbot | Merge Request Status | open => approved |
2022-06-03 09:45 | hgbot | Resolution | open => fixed |
2022-06-03 09:45 | hgbot | Status | new => closed |
2022-06-03 09:45 | hgbot | Fixed in Version | => PR22Q3 |
2022-06-03 09:45 | hgbot | Note Added: 0138021 | |
2022-06-03 09:45 | hgbot | Note Added: 0138022 |
Copyright © 2000 - 2009 MantisBT Group |