Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0049311Openbravo ERPA. Platformpublic2022-05-12 15:592022-06-03 09:45
Reporteralostale 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0049311: jest coverage report is inaccurate
DescriptionJest coverage report is inaccurate because:
1. It is reporting coverage on some libraries (ie. redux)
2. It only reports coverage on files that are under test or imported by them, not taking into account files that are completely untested
Steps To Reproduce1. In a retail instance run: npm run coverage
2. Check:
  - There is coverage report for redux libraries
  - There is no coverage report for untested files (ie. SetContextAndPopup.js)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-05-12 15:59alostaleNew Issue
2022-05-12 15:59alostaleAssigned To => Triage Platform Base
2022-05-12 15:59alostaleOBNetwork customer => No
2022-05-12 15:59alostaleModules => Core
2022-05-12 15:59alostaleTriggers an Emergency Pack => No
2022-05-12 16:04hgbotMerge Request Status => open
2022-05-12 16:04hgbotNote Added: 0137225
2022-06-03 09:44hgbotMerge Request Statusopen => approved
2022-06-03 09:45hgbotResolutionopen => fixed
2022-06-03 09:45hgbotStatusnew => closed
2022-06-03 09:45hgbotFixed in Version => PR22Q3
2022-06-03 09:45hgbotNote Added: 0138021
2022-06-03 09:45hgbotNote Added: 0138022

Notes
(0137225)
hgbot   
2022-05-12 16:04   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/595 [^]
(0138021)
hgbot   
2022-06-03 09:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: feef8e6c5a51312ca1d2432ea419c0dcbef97454
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 03-06-2022 09:44:56
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/feef8e6c5a51312ca1d2432ea419c0dcbef97454 [^]

fixes BUG-49311: jest coverage report is inaccurate

Explicitly defines which are the files that should be taken into
consideration for the coverage report:
  * includes web-jspack and web/*/app, react pos and post indexeddb enyo
    pos files. This makes untested files to be included also.
  * excludes libraries and other non relevant paths

---
M package.json
---
(0138022)
hgbot   
2022-06-03 09:45   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/595 [^]