Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0048802
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2022-03-15 17:072022-03-29 17:20
ReporterjmelinView Statuspublic 
Assigned Toelara 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0048802: JIRA 2759 - POP - Qty input in POP "Select product from orders" needs to be validated

DescriptionWhen trying to import a proof of payment, the following error is triggered :
org.openbravo.base.validation.ValidationException: OBPOS2_Pop_Lines.originalFraction: Value too long. Length 34, maximum allowed 9

This happen because you can enter a value that is not a number
Steps To ReproduceConnect to livebuild backoffice
Create a "Proof of payment wrapper" entry in the corresponding windows
In "Organization", select "vallblanca store" and then tab "Proof of payment wrapper"
Add the prevoius wrapper and set to active

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "111111111/222222222" in the field
click on the button "x/y" again then "OK"
validate the Pop and print "All"

In the BO, the import is in error
TagsNo tags attached.
Attached Files? file icon jsondata.json [^] (2,907 bytes) 2022-03-15 17:31
? file icon erreormessage [^] (5,557 bytes) 2022-03-15 17:31 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0048805 closedelara JIRA 2766: Errors while importing POP should not block cashup 

-  Notes
(0135852)
hgbot (developer)
2022-03-18 13:10

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/877 [^]
(0135858)
hgbot (developer)
2022-03-18 16:53

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7fc96171127e9b68a2f75275a3319f461bfa7e7f
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 18-03-2022 15:52:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7fc96171127e9b68a2f75275a3319f461bfa7e7f [^]

Fixed ISSUE-48802: Add validation to verify if the originalFraction is correct

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentSelectedLinesActionPreparation.js
---
(0135859)
hgbot (developer)
2022-03-18 16:53

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/877 [^]
(0135969)
jmelin (reporter)
2022-03-23 14:49

Connect to livebuild backoffice
Create a "Proof of payment wrapper" entry in the corresponding windows
In "Organization", select "vallblanca store" and then tab "Proof of payment wrapper"
Add the prevoius wrapper and set to active

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "5"
Then "OK"

=> nothing happen, in Console, you can see the following
"Uncaught (in promise) dodivide(): Divide by 0"
(0135971)
jmelin (reporter)
2022-03-23 14:51

Other case:

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "5", click on "x/y" again
Select the 0 from "0/5" and remove it (backspace)
Then "OK"

=> nothing happen, in Console, you can see the following
"FractionIncrementalInput.jsx:129 Uncaught (in promise) BigDecimal(): Not a number: "
(0135972)
jmelin (reporter)
2022-03-23 14:57

Other case:

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "1/11711"
Then "OK"
(0136103)
hgbot (developer)
2022-03-28 17:12

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/892 [^]
(0136136)
hgbot (developer)
2022-03-29 17:20

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/892 [^]
(0136137)
hgbot (developer)
2022-03-29 17:20

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2e42ea5b47454fb1a16d289e5f926548a61289b7
Author: Eduardo Lara <eduardo.lara@smfconsulting.es>
Date: 29-03-2022 17:16:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2e42ea5b47454fb1a16d289e5f926548a61289b7 [^]

Fixes ISSUE-48802: Improve fractional quantity validation

---
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/SelectLinesFractionIncrementalInput/SelectLinesFractionIncrementalInput.jsx
---

- Issue History
Date Modified Username Field Change
2022-03-15 17:07 jmelin New Issue
2022-03-15 17:07 jmelin Assigned To => Retail
2022-03-15 17:07 jmelin Triggers an Emergency Pack => No
2022-03-15 17:08 jmelin Assigned To Retail => jmelin
2022-03-15 17:30 jmelin Assigned To jmelin => Retail
2022-03-15 17:30 jmelin Steps to Reproduce Updated View Revisions
2022-03-15 17:31 jmelin File Added: jsondata.json
2022-03-15 17:31 jmelin File Added: erreormessage
2022-03-15 18:05 guilleaer Relationship added related to 0048805
2022-03-16 09:28 guilleaer Summary JIRA 2759 - POP - ValidationException when trying to import proof of payment => JIRA 2759 - POP - Qty input in POP "Select product from orders" needs to be validated
2022-03-17 10:19 javierRodriguez Status new => scheduled
2022-03-17 10:19 javierRodriguez Assigned To Retail => javierRodriguez
2022-03-18 13:10 hgbot Note Added: 0135852
2022-03-18 16:53 hgbot Resolution open => fixed
2022-03-18 16:53 hgbot Status scheduled => closed
2022-03-18 16:53 hgbot Note Added: 0135858
2022-03-18 16:53 hgbot Note Added: 0135859
2022-03-23 14:49 jmelin Assigned To javierRodriguez => guilleaer
2022-03-23 14:49 jmelin Note Added: 0135969
2022-03-23 14:49 jmelin Status closed => new
2022-03-23 14:49 jmelin Resolution fixed => open
2022-03-23 14:51 jmelin Note Added: 0135971
2022-03-23 14:57 jmelin Note Added: 0135972
2022-03-25 17:26 elara Assigned To guilleaer => elara
2022-03-25 21:20 elara Status new => scheduled
2022-03-28 17:12 hgbot Note Added: 0136103
2022-03-29 17:20 hgbot Note Added: 0136136
2022-03-29 17:20 hgbot Resolution open => fixed
2022-03-29 17:20 hgbot Status scheduled => closed
2022-03-29 17:20 hgbot Note Added: 0136137


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker