Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048802POS2POSpublic2022-03-15 17:072022-03-29 17:20
Reporterjmelin 
Assigned Toelara 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048802: JIRA 2759 - POP - Qty input in POP "Select product from orders" needs to be validated
DescriptionWhen trying to import a proof of payment, the following error is triggered :
org.openbravo.base.validation.ValidationException: OBPOS2_Pop_Lines.originalFraction: Value too long. Length 34, maximum allowed 9

This happen because you can enter a value that is not a number
Steps To ReproduceConnect to livebuild backoffice
Create a "Proof of payment wrapper" entry in the corresponding windows
In "Organization", select "vallblanca store" and then tab "Proof of payment wrapper"
Add the prevoius wrapper and set to active

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "111111111/222222222" in the field
click on the button "x/y" again then "OK"
validate the Pop and print "All"

In the BO, the import is in error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048805 closed elara JIRA 2766: Errors while importing POP should not block cashup 
Attached Files? jsondata.json (2,907) 2022-03-15 17:31
https://issues.openbravo.com/file_download.php?file_id=16761&type=bug
? erreormessage (5,557) 2022-03-15 17:31
https://issues.openbravo.com/file_download.php?file_id=16762&type=bug
Issue History
Date ModifiedUsernameFieldChange
2022-03-15 17:07jmelinNew Issue
2022-03-15 17:07jmelinAssigned To => Retail
2022-03-15 17:07jmelinTriggers an Emergency Pack => No
2022-03-15 17:08jmelinAssigned ToRetail => jmelin
2022-03-15 17:30jmelinAssigned Tojmelin => Retail
2022-03-15 17:30jmelinSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=23779#r23779
2022-03-15 17:31jmelinFile Added: jsondata.json
2022-03-15 17:31jmelinFile Added: erreormessage
2022-03-15 18:05guilleaerRelationship addedrelated to 0048805
2022-03-16 09:28guilleaerSummaryJIRA 2759 - POP - ValidationException when trying to import proof of payment => JIRA 2759 - POP - Qty input in POP "Select product from orders" needs to be validated
2022-03-17 10:19javierRodriguezStatusnew => scheduled
2022-03-17 10:19javierRodriguezAssigned ToRetail => javierRodriguez
2022-03-18 13:10hgbotNote Added: 0135852
2022-03-18 16:53hgbotResolutionopen => fixed
2022-03-18 16:53hgbotStatusscheduled => closed
2022-03-18 16:53hgbotNote Added: 0135858
2022-03-18 16:53hgbotNote Added: 0135859
2022-03-23 14:49jmelinAssigned TojavierRodriguez => guilleaer
2022-03-23 14:49jmelinNote Added: 0135969
2022-03-23 14:49jmelinStatusclosed => new
2022-03-23 14:49jmelinResolutionfixed => open
2022-03-23 14:51jmelinNote Added: 0135971
2022-03-23 14:57jmelinNote Added: 0135972
2022-03-25 17:26elaraAssigned Toguilleaer => elara
2022-03-25 21:20elaraStatusnew => scheduled
2022-03-28 17:12hgbotNote Added: 0136103
2022-03-29 17:20hgbotNote Added: 0136136
2022-03-29 17:20hgbotResolutionopen => fixed
2022-03-29 17:20hgbotStatusscheduled => closed
2022-03-29 17:20hgbotNote Added: 0136137

Notes
(0135852)
hgbot   
2022-03-18 13:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/877 [^]
(0135858)
hgbot   
2022-03-18 16:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7fc96171127e9b68a2f75275a3319f461bfa7e7f
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 18-03-2022 15:52:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7fc96171127e9b68a2f75275a3319f461bfa7e7f [^]

Fixed ISSUE-48802: Add validation to verify if the originalFraction is correct

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentSelectedLinesActionPreparation.js
---
(0135859)
hgbot   
2022-03-18 16:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/877 [^]
(0135969)
jmelin   
2022-03-23 14:49   
Connect to livebuild backoffice
Create a "Proof of payment wrapper" entry in the corresponding windows
In "Organization", select "vallblanca store" and then tab "Proof of payment wrapper"
Add the prevoius wrapper and set to active

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "5"
Then "OK"

=> nothing happen, in Console, you can see the following
"Uncaught (in promise) dodivide(): Divide by 0"
(0135971)
jmelin   
2022-03-23 14:51   
Other case:

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "5", click on "x/y" again
Select the 0 from "0/5" and remove it (backspace)
Then "OK"

=> nothing happen, in Console, you can see the following
"FractionIncrementalInput.jsx:129 Uncaught (in promise) BigDecimal(): Not a number: "
(0135972)
jmelin   
2022-03-23 14:57   
Other case:

Connect to livebuild VBS2
Create an order with several product and pay it
Click on "Last Order PoP" and click "Create new" then "select products from order"
CLick on the field to edit the quantity of a product manually
In the pinpad, click on the button "x/y"
Type "1/11711"
Then "OK"
(0136103)
hgbot   
2022-03-28 17:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/892 [^]
(0136136)
hgbot   
2022-03-29 17:20   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/892 [^]
(0136137)
hgbot   
2022-03-29 17:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2e42ea5b47454fb1a16d289e5f926548a61289b7
Author: Eduardo Lara <eduardo.lara@smfconsulting.es>
Date: 29-03-2022 17:16:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2e42ea5b47454fb1a16d289e5f926548a61289b7 [^]

Fixes ISSUE-48802: Improve fractional quantity validation

---
M web-jspack/org.openbravo.pos2/src/components/SelectLines/SelectedLinesGrid/SelectLinesFractionIncrementalInput/SelectLinesFractionIncrementalInput.jsx
---