Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048001 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Sessions | minor | have not tried | 2021-11-06 12:31 | 2021-11-16 14:07 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0048001: Remove obsolete storeserver related code from sessions module | |||||||
| Description | This module still retains some code related to the obsolete storeserver project. As that is long obsolete it should be cleaned up. Code is in CloseStoreUtils which apart from closing the session locally in the database also allows to sent a request to the 'other' server (central or store) to do the same Then 'other side' of that request is "CloseServerSellerSessions extends MobileServerMessageHandler" file which receives that requests | |||||||
| Steps To Reproduce | grep -Iir storeserver | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0132881) hgbot (developer) 2021-11-06 12:36 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/28 [^] |
|
(0133110) hgbot (developer) 2021-11-16 14:07 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/28 [^] |
|
(0133111) hgbot (developer) 2021-11-16 14:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^] Changeset: 0839db0dec0e12fc33c515cd821f9d9c887dd030 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 2021-11-16T14:06:23+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/0839db0dec0e12fc33c515cd821f9d9c887dd030 [^] Fixes ISSUE-48001 Remove obsolete storeserver code CloseStoreUtils apart from closing sessions locally has code conditional on Openbravo.properties having a mobile.server.key defined. in that case it used sendMessageToStore / sendMessageToCentral to request those 'others' servers to also close the sessions. As that logic does no longer sense with the storeserver project obsolete remove it. - Remove the calling part in CloseStoreUtils - Remove the whole file CloseServerSellerSessions which was the 'receiving side' of that call. - Link between those was apparently the type = closeSessions --- M src/org/openbravo/retail/sessions/CloseStoreUtils.java R src/org/openbravo/retail/sessions/CloseServerSellerSessions.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-06 12:31 | shuehner | New Issue | |
| 2021-11-06 12:31 | shuehner | Assigned To | => shuehner |
| 2021-11-06 12:31 | shuehner | Triggers an Emergency Pack | => No |
| 2021-11-06 12:31 | shuehner | Issue generated from | 0047999 |
| 2021-11-06 12:31 | shuehner | Relationship added | blocks 0048000 |
| 2021-11-06 12:36 | hgbot | Note Added: 0132881 | |
| 2021-11-06 13:54 | shuehner | Issue cloned | 0048002 |
| 2021-11-10 09:49 | shuehner | Relationship added | related to 0048023 |
| 2021-11-10 09:50 | shuehner | Status | new => scheduled |
| 2021-11-16 14:07 | hgbot | Note Added: 0133110 | |
| 2021-11-16 14:07 | hgbot | Resolution | open => fixed |
| 2021-11-16 14:07 | hgbot | Status | scheduled => closed |
| 2021-11-16 14:07 | hgbot | Note Added: 0133111 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |