Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0048001Retail ModulesSessionspublic2021-11-06 12:312021-11-16 14:07
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0048001: Remove obsolete storeserver related code from sessions module
DescriptionThis module still retains some code related to the obsolete storeserver project.

As that is long obsolete it should be cleaned up.

Code is in CloseStoreUtils which apart from closing the session locally in the database also allows to sent a request to the 'other' server (central or store) to do the same
Then 'other side' of that request is "CloseServerSellerSessions extends MobileServerMessageHandler" file which receives that requests
Steps To Reproducegrep -Iir storeserver
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048023 closed rqueralta Remove obsolete usage of MultiServerJSONProcess (storeserver) from sessions module 
blocks defect 0048000 closed shuehner Remove obsolete storeserver related code from mobile.core 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-06 12:31shuehnerNew Issue
2021-11-06 12:31shuehnerAssigned To => shuehner
2021-11-06 12:31shuehnerTriggers an Emergency Pack => No
2021-11-06 12:31shuehnerIssue generated from0047999
2021-11-06 12:31shuehnerRelationship addedblocks 0048000
2021-11-06 12:36hgbotNote Added: 0132881
2021-11-06 13:54shuehnerIssue cloned0048002
2021-11-10 09:49shuehnerRelationship addedrelated to 0048023
2021-11-10 09:50shuehnerStatusnew => scheduled
2021-11-16 14:07hgbotNote Added: 0133110
2021-11-16 14:07hgbotResolutionopen => fixed
2021-11-16 14:07hgbotStatusscheduled => closed
2021-11-16 14:07hgbotNote Added: 0133111

Notes
(0132881)
hgbot   
2021-11-06 12:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/28 [^]
(0133110)
hgbot   
2021-11-16 14:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/28 [^]
(0133111)
hgbot   
2021-11-16 14:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 0839db0dec0e12fc33c515cd821f9d9c887dd030
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-11-16T14:06:23+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/0839db0dec0e12fc33c515cd821f9d9c887dd030 [^]

Fixes ISSUE-48001 Remove obsolete storeserver code

CloseStoreUtils apart from closing sessions locally has code conditional
on Openbravo.properties having a mobile.server.key defined.

in that case it used sendMessageToStore / sendMessageToCentral to
request those 'others' servers to also close the sessions.

As that logic does no longer sense with the storeserver project obsolete
remove it.

- Remove the calling part in CloseStoreUtils
- Remove the whole file CloseServerSellerSessions which was the
  'receiving side' of that call.
  - Link between those was apparently the type = closeSessions

---
M src/org/openbravo/retail/sessions/CloseStoreUtils.java
R src/org/openbravo/retail/sessions/CloseServerSellerSessions.java
---