Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047855 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [POS2] POS | major | have not tried | 2021-10-14 18:30 | 2021-10-25 16:08 | |||
| Reporter | javierRodriguez | View Status | public | |||||
| Assigned To | javierRodriguez | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047855: Refactor divide in equal parts in Proof of payment | |||||||
| Description | Divide in equal parts does not create "equal" pops due to is trying to fit exactly with ticket lines. | |||||||
| Steps To Reproduce | having a 3.60€ ticket, try to divide it in 7 part and check that there is 6 parts with 0.51€ and an other one with 0.54€. it does not divide the rounding differences with the other pops. | |||||||
| Proposed Solution | Transform Divide algorithm to execute N fill in amounts | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0132455) hgbot (developer) 2021-10-19 15:44 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/709 [^] |
|
(0132609) hgbot (developer) 2021-10-25 16:08 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/709 [^] |
|
(0132610) hgbot (developer) 2021-10-25 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0c92eb9a0348c382b944ec08508ab3117d2b6daf Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-10-25T16:06:23+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0c92eb9a0348c382b944ec08508ab3117d2b6daf [^] Fixed ISSUE-47855: Refactor Divide in equal parts function to use Fill in amount algorithm n-times --- M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js --- |
|
(0132611) hgbot (developer) 2021-10-25 16:08 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 5784bcdf1eece4b069c1d53165fe7ea775389b77 Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-10-25T16:06:23+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5784bcdf1eece4b069c1d53165fe7ea775389b77 [^] Related to ISSUE-47855: Use currency precision --- M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js --- |
|
(0132612) hgbot (developer) 2021-10-25 16:08 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 509a73a30d7e91a152d60f6e71791ba631dfe67c Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-10-25T16:06:23+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/509a73a30d7e91a152d60f6e71791ba631dfe67c [^] Related to ISSUE-47855: Remove qty set in divide in equal parts, fix popList to filter by ticket id and create test --- M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentDivideActionPreparation.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentFillActionPreparation.js M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-10-14 18:30 | javierRodriguez | New Issue | |
| 2021-10-14 18:30 | javierRodriguez | Assigned To | => javierRodriguez |
| 2021-10-14 18:30 | javierRodriguez | OBNetwork customer | => No |
| 2021-10-14 18:30 | javierRodriguez | Triggers an Emergency Pack | => No |
| 2021-10-14 18:30 | javierRodriguez | Status | new => scheduled |
| 2021-10-15 12:34 | guilleaer | Relationship added | has duplicate 0047673 |
| 2021-10-19 15:44 | hgbot | Merge Request Status | => open |
| 2021-10-19 15:44 | hgbot | Note Added: 0132455 | |
| 2021-10-25 15:58 | hgbot | Merge Request Status | open => approved |
| 2021-10-25 16:08 | hgbot | Note Added: 0132609 | |
| 2021-10-25 16:08 | hgbot | Resolution | open => fixed |
| 2021-10-25 16:08 | hgbot | Status | scheduled => closed |
| 2021-10-25 16:08 | hgbot | Note Added: 0132610 | |
| 2021-10-25 16:08 | hgbot | Note Added: 0132611 | |
| 2021-10-25 16:08 | hgbot | Note Added: 0132612 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |