Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047855POS2POSpublic2021-10-14 18:302021-10-25 16:08
ReporterjavierRodriguez 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047855: Refactor divide in equal parts in Proof of payment
DescriptionDivide in equal parts does not create "equal" pops due to is trying to fit exactly with ticket lines.
Steps To Reproducehaving a 3.60€ ticket, try to divide it in 7 part and check that there is 6 parts with 0.51€ and an other one with 0.54€. it does not divide the rounding differences with the other pops.
Proposed SolutionTransform Divide algorithm to execute N fill in amounts
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0047856TAP closed javierRodriguez Refactor divide in equal parts in Proof of payment 
has duplicate defect 0047673TAP closed javierRodriguez JIRA 2304 - Proof of payment - rounding are not properly executed in some cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-10-14 18:30javierRodriguezNew Issue
2021-10-14 18:30javierRodriguezAssigned To => javierRodriguez
2021-10-14 18:30javierRodriguezTriggers an Emergency Pack => No
2021-10-14 18:30javierRodriguezStatusnew => scheduled
2021-10-15 12:34guilleaerRelationship addedhas duplicate 0047673
2021-10-19 15:44hgbotNote Added: 0132455
2021-10-25 16:08hgbotNote Added: 0132609
2021-10-25 16:08hgbotResolutionopen => fixed
2021-10-25 16:08hgbotStatusscheduled => closed
2021-10-25 16:08hgbotNote Added: 0132610
2021-10-25 16:08hgbotNote Added: 0132611
2021-10-25 16:08hgbotNote Added: 0132612

Notes
(0132455)
hgbot   
2021-10-19 15:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/709 [^]
(0132609)
hgbot   
2021-10-25 16:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/709 [^]
(0132610)
hgbot   
2021-10-25 16:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0c92eb9a0348c382b944ec08508ab3117d2b6daf
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-10-25T16:06:23+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0c92eb9a0348c382b944ec08508ab3117d2b6daf [^]

Fixed ISSUE-47855: Refactor Divide in equal parts function to use Fill in amount algorithm n-times

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js
---
(0132611)
hgbot   
2021-10-25 16:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5784bcdf1eece4b069c1d53165fe7ea775389b77
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-10-25T16:06:23+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5784bcdf1eece4b069c1d53165fe7ea775389b77 [^]

Related to ISSUE-47855: Use currency precision

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js
---
(0132612)
hgbot   
2021-10-25 16:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 509a73a30d7e91a152d60f6e71791ba631dfe67c
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-10-25T16:06:23+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/509a73a30d7e91a152d60f6e71791ba631dfe67c [^]

Related to ISSUE-47855: Remove qty set in divide in equal parts, fix popList to filter by ticket id and create test

---
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/GeneratePopDivideEquallyUtils.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentDivideActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/actions/AddNewProofOfPaymentFillActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/utils/GeneratePopDivideEqually.js
---